Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 562: Add canonical reference link #4099

Merged
merged 2 commits into from
Oct 31, 2024
Merged

PEP 562: Add canonical reference link #4099

merged 2 commits into from
Oct 31, 2024
+3 −0

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Oct 31, 2024 •
edited by github-actions bot
Loading

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

Closes #4068

📚 Documentation preview 📚: https://pep-previews--4099.org.readthedocs.build/

@willingc willingc requested a review from ilevkivskyi as a code owner October 31, 2024 06:41
@willingc
Copy link
Contributor Author

@JelleZijlstra This is the first time that I'm adding a canonical link. I wasn't sure if it was okay to use the long link to the subsection of the page. Please let me know what needs to be updated. Thanks!

skirpichev
skirpichev reviewed Oct 31, 2024
View reviewed changes
peps/pep-0562.rst Outdated Show resolved Hide resolved
@willingc @skirpichev
Update peps/pep-0562.rst
7a11001 
Co-authored-by: Sergey B Kirpichev <[email protected]>
@willingc willingc merged commit bd7b43a into python:main Oct 31, 2024
5 checks passed
@willingc willingc deleted the iss-4068 branch October 31, 2024 21:24
gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
@willingc @skirpichev @gvanrossum
PEP 562: Add canonical reference link (python#4099)
dd951eb 
* Add canonical reference link for pep 562

* Update peps/pep-0562.rst

Co-authored-by: Sergey B Kirpichev <[email protected]>

---------

Co-authored-by: Sergey B Kirpichev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev left review comments

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PEP 562: add canonical module __getattr__ ref
3 participants
@willingc @skirpichev @ilevkivskyi