Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple definitions for Py_fclose #130

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Fix multiple definitions for Py_fclose #130

merged 1 commit into from
Jan 26, 2025

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Jan 26, 2025

While testing the lastest changes in pythoncapi_compat.h with mypy, I encountered this error

pythoncapi_compat.h:1972: multiple definition of `Py_fclose'

Believe Py_fclose is missing static inline.

vstinner
vstinner approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit d24c201 into python:main Jan 26, 2025
21 checks passed
@vstinner
Copy link
Member

Oops, thanks for the fix!

@cdce8p cdce8p deleted the cdce8p-patch-1 branch January 26, 2025 11:51
@cdce8p cdce8p mentioned this pull request Jan 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdce8p @vstinner