New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Improve static deploy" #2621

Merged

ewdurbin merged 1 commit into main from revert-2609-static_deploy

Sep 30, 2024

Member

ewdurbin commented Sep 30, 2024

Reverts #2609

It didn't work, the add headers function didn't seem to do what it said on the tin and the postdeploy command wasn't accessible to manage.py (since pydotorg app isn't directly installed).
This would have made things.... worse? Since old cached pages would have no chance of getting their static asset versions.

A better approach would be to not cache 404s for /static.


          Revert "Improve static deploy (#2609)"

7f0e2ac

This reverts commit 18e1d74.

ewdurbin requested a review from JacobCoffee as a code owner

September 30, 2024 18:51

JacobCoffee approved these changes

View reviewed changes

ewdurbin merged commit 4c44d80 into main

6 checks passed

ewdurbin deleted the revert-2609-static_deploy branch

September 30, 2024 19:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet