Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xxhash types (not before April 2023) #7142

Closed
faresbakhit opened this issue Feb 5, 2022 · 4 comments · Fixed by #9985
Closed

Remove xxhash types (not before April 2023) #7142

faresbakhit opened this issue Feb 5, 2022 · 4 comments · Fixed by #9985
Labels
stubs: removal Pending removal of third-party distributions

Comments

@faresbakhit
Copy link
Contributor

ifduyue/python-xxhash added type hints to master the last month (here in #4689), however the latest release doesn't ship with __init__.pyi nor py.typed. so wait until xxhash's next release and remove ./stubs/xxhash from here?

@JelleZijlstra
Copy link
Member

Thanks! Our rule is to remove the stubs 6 months after the first release that ships stubs.

@srittau srittau added the stubs: removal Pending removal of third-party distributions label Feb 6, 2022
@srittau srittau changed the title Remove xxhash types Remove xxhash types (not before ?) Feb 22, 2022
@srittau
Copy link
Collaborator

srittau commented Mar 14, 2022

xxhash doesn't seem to ship with py.typed, and I can't find any mention of py.typed in the repository either. I am going to close this until xxhash adds support for type hints.

@srittau srittau closed this as completed Mar 14, 2022
@hauntsaninja
Copy link
Collaborator

Sort of seems the intention was to add a py.typed though (ifduyue/python-xxhash#51 talks about PEP 561), so could mention it to the upstream project if anyone is so inclined.

@AlexWaygood AlexWaygood reopened this Oct 20, 2022
@AlexWaygood AlexWaygood changed the title Remove xxhash types (not before ?) Remove xxhash types (not before April 2023) Oct 20, 2022
@AlexWaygood
Copy link
Member

Upstream just cut a release with a py.typed file: #8935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stubs: removal Pending removal of third-party distributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants