Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docutils: Input can take bytearray #10108

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Conversation

JelleZijlstra
Copy link
Member

Part of #9006

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big day for our docutils stubs

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

pandas (https://github.com/pandas-dev/pandas) got 1.09x faster (86.4s -> 79.0s)

@AlexWaygood
Copy link
Member

Diff from mypy_primer, showing the effect of this PR on open source code:

pandas (https://github.com/pandas-dev/pandas) got 1.09x faster (86.4s -> 79.0s)

Nice

@AlexWaygood AlexWaygood merged commit 0f270e6 into python:main Apr 29, 2023
@JelleZijlstra JelleZijlstra deleted the docutils branch April 29, 2023 15:18
@JelleZijlstra
Copy link
Member Author

Diff from mypy_primer, showing the effect of this PR on open source code:

pandas (https://github.com/pandas-dev/pandas) got 1.09x faster (86.4s -> 79.0s)

Nice

That's definitely a real improvement and not noise.

@JelleZijlstra JelleZijlstra restored the docutils branch September 10, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants