fcntl: various improvements #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hauntsaninja
commented
Jan 28, 2020
hauntsaninja
commented
- use overload for fcntl.ioctl
- use overload for fcntl.fcntl
- mark positional-only args
|
Little less sure about this one...
|
| __request: int, | ||
| __arg: bytearray, | ||
| __mutate_flag: Literal[True] = ...) -> int: ... | ||
| @overload |
There was a problem hiding this comment.
I think this overload can be omitted (note that bytearray is treated as a subtype of bytes to the typechecker).
added 4 commits
February 4, 2020 16:04
The comment about depending on the type of arg seems incorrect python@bf50135 I checked the docs and examples, CPython implementation and CPython tests, but I might be missing something
Based off of docs and examples
Follows the approach in python#2610
Rahix
added a commit
to Rahix/tbot
that referenced
this pull request
Mar 11, 2020
A recent change in Python's typeshed [1] leads to mypy complaining that there is no overload for ioctl() with the signature `int, int, bytes`. By adding an explicit `mutate_flag=False`, another overload is selected and mypy stays quiet. [1]: python/typeshed#3680 Signed-off-by: Harald Seiler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.