Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultSelector in selectors.pyi is not a type, it is an alias #7087

Closed
wants to merge 14 commits into from
Closed

DefaultSelector in selectors.pyi is not a type, it is an alias #7087

wants to merge 14 commits into from

Conversation

sobolevn
Copy link
Member

AlexWaygood
AlexWaygood reviewed Jan 30, 2022
View reviewed changes
stdlib/selectors.pyi Outdated Show resolved Hide resolved
@sobolevn @AlexWaygood
Update stdlib/selectors.pyi
b012f97 
Co-authored-by: Alex Waygood <[email protected]>
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@sobolevn
Copy link
Member Author

Mypy output looks broken. I will investigate it later today.

@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@sobolevn
Copy link
Member Author

stdlib/selectors.pyi:68: error: Value of type "Type[type]" is not indexable

Is the error to investigate.

@sobolevn
Copy link
Member Author

Also the problem with nested Union[Union[]] and stubtest

@sobolevn
Copy link
Member Author

Ok, I don't know why this happens and how to fix it:

 error: selectors.DefaultSelector variable differs from runtime type abc.ABCMeta
Stub: at line 68
Union[Type[selectors.KqueueSelector], Type[selectors.DevpollSelector], Type[selectors.SelectSelector], Type[selectors.PollSelector], Type[selectors.EpollSelector]]
Runtime: at line 442 in file /opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/selectors.py
<class 'selectors.EpollSelector'>

I will create a new issue in mypy. Sorry for the noise! 🙏

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood
Copy link
Member

My whole inbox rn:
Screenshot_20220130-160631_Email

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@sobolevn
Copy link
Member Author

@AlexWaygood I am sorry 😞

@AlexWaygood
Copy link
Member

@AlexWaygood I am sorry 😞

Don't be, it's fine 😄 I should probably adjust my email notification settings more than anything else

@srittau srittau added the status: deferred Issue or PR deferred until some precondition is fixed label Feb 2, 2022
@srittau
Copy link
Collaborator

srittau commented Feb 2, 2022

I added the "deferred" label for now, until the mypy issues are sorted out.

@AlexWaygood AlexWaygood mentioned this pull request Feb 4, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

Assignees
No one assigned
Labels
status: deferred Issue or PR deferred until some precondition is fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @AlexWaygood @srittau