dateparser: Remove redundant import of _typeshed.Self
#8041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't exist at runtime: ```python >>> import dateparser.date >>> dateparser.date.Self Traceback (most recent call last): File "<stdin>", line 1, in <module> AttributeError: module 'dateparser.date' has no attribute 'Self' ``` ...and it's not used in the stub either. I'm not sure why stubtest didn't pick it up. My stubtest patch over at python/mypy#12214 _does_ pick it up (and I'm not sure why that is, either... but it's a true positive!)
|
@hauntsaninja, this is the only hit in the third-party stubs that was picked up by my python/mypy#12214 stubtest patch. The patch has little impact if stubtest is run with |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
approved these changes
Jun 8, 2022
|
@AlexWaygood I got around to looking into this. Turns out I fixed it in python/mypy#12851 |
Heh, that makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't exist at runtime:
...and it's not used in the stub either.
I'm not sure why stubtest didn't pick it up. My stubtest patch over at python/mypy#12214 does pick it up (and I'm not sure why that is, either... but it's a true positive!)