Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subprocess: Improve bytes-related types #9100

Merged
merged 10 commits into from
Jan 12, 2023
Merged

subprocess: Improve bytes-related types #9100

merged 10 commits into from
Jan 12, 2023

Conversation

JelleZijlstra
Copy link
Member

  • subprocess: improve bytes-related types
  • replace _TXT alias

@JelleZijlstra JelleZijlstra mentioned this pull request Nov 5, 2022
Open
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
Copy link
Member Author

For the mypy-primer issue, seems like mypy incorrectly picks a specific overload at https://github.com/pytest-dev/pytest/blob/2f33ea87c8d303c3439655eb2bea24483bffde5e/src/_pytest/_py/path.py#L1176.

@JelleZijlstra JelleZijlstra marked this pull request as draft November 5, 2022 04:02
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra JelleZijlstra mentioned this pull request Nov 12, 2022
Open
@github-actions

This comment has been minimized.

Sign in to view
JelleZijlstra
JelleZijlstra commented Nov 12, 2022
View reviewed changes
stdlib/subprocess.pyi Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra JelleZijlstra marked this pull request as ready for review November 12, 2022 03:16
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

hauntsaninja
hauntsaninja approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, didn't check for any errors of omission

@JelleZijlstra JelleZijlstra merged commit b9eab63 into python:main Jan 12, 2023
@JelleZijlstra JelleZijlstra deleted the subprocess branch January 12, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelleZijlstra @hauntsaninja