Built-in generic now work without limitations #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/source/stubs.rst
Outdated
|
|
||
| In these cases, the appropriate types from ``typing`` must be used. | ||
| PEP 585 [#pep585]_ built-in generics are supported and should be used instead | ||
| of the corresponding types from ``typing``. | ||
|
|
||
| Using imports from ``collections.abc`` instead of ``typing`` is | ||
| generally possible and recommended. |
There was a problem hiding this comment.
Can we drop the "generally" here too? I don't think there are any exceptions left.
Also, it would be good to have some examples in this section. We can list bad examples like "from typing import Sequence" and "List[int]" and good ones like "from collections.abc import Sequence" and "list[int]".
There was a problem hiding this comment.
There are several exceptions that I know of — but it may be that these only apply to typeshed:
There was a problem hiding this comment.
I added a few examples, although I only used positive examples as in other examples in this section.
Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1067