Get fbgemm::pack_segments tests working (#2076) #2093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D50513309 |
Summary: Follow https://docs.google.com/document/d/1_W62p8WJOQQUzPsJYa7s701JXt0qf2OfLub2sbkHOaU/edit?usp=sharing to get `fbgemm::pack_segments` tests passing in `failures_dict.json` Reviewed By: zou3519 Differential Revision: D50513309
williamwen42
force-pushed
the
export-D50513309
branch
from
90f89e3 to
fa0fb7c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50513309 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
Summary: Follow https://docs.google.com/document/d/1_W62p8WJOQQUzPsJYa7s701JXt0qf2OfLub2sbkHOaU/edit?usp=sharing to get `fbgemm::pack_segments` tests passing in `failures_dict.json` Reviewed By: zou3519 Differential Revision: D50513309
facebook-github-bot
force-pushed
the
export-D50513309
branch
from
fa0fb7c to
a5ce268
Compare
williamwen42
force-pushed
the
export-D50513309
branch
from
a5ce268 to
fa0fb7c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50513309 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50513309 |
|
This pull request has been merged in 049f2a9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow https://docs.google.com/document/d/1_W62p8WJOQQUzPsJYa7s701JXt0qf2OfLub2sbkHOaU/edit?usp=sharing to get
fbgemm::pack_segmentstests passing infailures_dict.jsonReviewed By: zou3519
Differential Revision: D50513309