Update calls to quantize_ everywhere
#496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/496
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 206eaa8 with merge base 05038a1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
approved these changes
Jul 10, 2024
msaroufim
reviewed
Jul 10, 2024
scripts/sam/eval_combo.py
Outdated
| @@ -316,7 +316,7 @@ def mlp_only(mod, name): | |||
| apply_fake_sparsity(predictor.model.image_encoder, | |||
| filter_fn=mlp_only) | |||
|
|
|||
| predictor.model.image_encoder = quantize(predictor.model.image_encoder, | |||
| predictor.model.image_encoder = quantize_(predictor.model.image_encoder, | |||
There was a problem hiding this comment.
actually this is making it unclear if the API is in place or not, same comment will apply to the whole repo
There was a problem hiding this comment.
oh it should be inplace, will update
Summary: att Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
jerryzh168
force-pushed
the
update-quantize
branch
from
45fcca7 to
206eaa8
Compare
msaroufim
approved these changes
Jul 10, 2024
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
Summary: att Test Plan: CI Reviewers: Subscribers: Tasks: Tags:
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
…rch#506) This reverts commit f65b53f42c3b6e304d9fe31d4d7edefc4b8eae7c as it just contains a typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
att
Test Plan:
CI
Reviewers:
Subscribers:
Tasks:
Tags: