-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-Breaking: Remove deprecated load_wav functions from backends #1362
Conversation
07445c3
to
525c129
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @iseessel
Thanks for working on this. Did you set the sox
command path from the artifact of the build process? This kind of precision mismatch happens when sox
command from system package manager (like apt
, brew
) is used. But anyway I do not think that your change is related to the failure you reported, so it should be fine.
The change looks good. I think CircleCI is hiccuping today. I will come back and see if we can trigger CI.
@mthrok hmm... I did use the locally built sox as opposed to the package. |
@iseessel Can you push something so that web hook is delivered? I cannot find a way to trigger CI. |
525c129
to
415f073
Compare
Strange... other PRs are triggering CI properly but not this one. let me see if closing and reopening helps. |
here it goes. |
@iseessel
|
Yep, I see a few failures, I'll work through them. @mthrok |
415f073
to
84d3c88
Compare
@iseessel other PRs landed on master is causing conflict. Could you resolve it? |
84d3c88
to
d3f6916
Compare
I've rebased and resolved conflicts. @mthrok Errors I've fixed:
Tests Still failing (Look unrelated to PR):
|
Thanks! |
Co-authored-by: holly1238 <[email protected]>
Testing Steps:
Run entire test suite.
I am getting one failure locally, but it doesn't look related to these changes.
Seems to have to do with imprecision of floating point arithemetic. Let me know if you want me to relax the threshold slightly -- it may be that the tests do not fail on CI build. (edit: I actually don't see the tests running on checks).
Let me know what you think. Thanks!