Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warning to sox backend #904

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Add deprecation warning to sox backend #904

merged 2 commits into from
Sep 15, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Sep 10, 2020

See #903

@mthrok mthrok mentioned this pull request Sep 11, 2020
Closed
vincentqb
vincentqb approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok merged commit 92b027b into pytorch:master Sep 15, 2020
@mthrok mthrok deleted the deprecate-sox branch September 15, 2020 18:27
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
Merge pull request pytorch#904 from jamesr66a/tb_namespaces
36ea6fc 
Update custom classes tutorial to include namespaces
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
@brianjo
Merge pull request pytorch#904 from SciPioneer/patch-1
5b528f5 
Clang-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mthrok @vincentqb