[Feature Request] allow both get_ic_generator and batch_initial_conditions to be used in the same call. #2609
Labels
enhancement
New feature or request
Comments
|
Hi @CompRhys! That sounds reasonable to me. Happy to review a PR for this. |
facebook-github-bot
pushed a commit
that referenced
this issue
Dec 3, 2024
#2610) Summary: ## Motivation See #2609 ### Have you read the [Contributing Guidelines on pull requests](https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md#pull-requests)? Yes Pull Request resolved: #2610 Test Plan: Basic testing of the code is easy the challenge is working out what the run on implications might be, will this break people's code? ## Related PRs facebook/Ax#2938 Reviewed By: Balandat Differential Revision: D66102868 Pulled By: saitcakmak fbshipit-source-id: b3491581a205b0fbe62edd670510e95f13e08177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🚀 Feature Request
When targeting a campaign I might want to include some points explicitly and then fill up the rest of the initial candidates using the strategies in botorch. This behaviour would be triggered by having
n_repeats > len(batch_initial_conditions)Motivation
Makes it much easier to do facebook/Ax#2938 as then all I have to worry about to get the desired behaviour for that to get merged is dropping the points from the given X_pareto front that do not satisfy the constraints
Pitch
this should be fairly minimal change in the logic to check that
raw_samples is not Noneand then just usingraw_samples-len(batch_initial_conditions)as the number of requested samples to the ic generator.Are you willing to open a pull request? (See CONTRIBUTING)
yes
Additional context
The text was updated successfully, but these errors were encountered: