Fixing issue with Windows timeout test #1946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #1946 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 177 177
Lines 15693 15693
=======================================
Hits 15685 15685
Misses 8 8 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The bug is strange. Windows with Python 3.11 is measuring an elapsed time of 0.0 after sleeping for 1e-3s, but timing in Windows is supposed to be more accurate in 3.11. |
esantorella
changed the title
saitcakmak
approved these changes
Jul 26, 2023
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@esantorella merged this pull request in cca54db. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context and explanation: Timing works differently on Windows, and its imprecision has caused test failures in the past. When we started testing against Python 3.11, Windows tests involving timing started failing flakily. Adding some print statements showed that when the tests failed, time elapsed was measured as 0.0 seconds when it should have been substantially more. This is odd, since timing (including
monotonic) was supposed to be more precise in Python 3.11. I couldn't debug this too thoroughly since I don't have access to a Windows machine outside of GitHub Actions.The fix: Increased
sleepfrom 1e-3s to 1e-2s in a test where we are making sure something times out within a limit of 1e-4s.Test plan:
I'm going to run units a few times to ensure that they pass consistently.