Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupled Acquisition Function #1948

Closed
wants to merge 1 commit into from

Conversation

sdaulton
Copy link
Contributor

Summary: Introduce an abstract class for decoupled acquisition functions

Differential Revision: D47710904

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Jul 26, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47710904

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jul 26, 2023
Summary:
Pull Request resolved: pytorch#1948

Introduce an abstract class for decoupled acquisition functions

Reviewed By: esantorella

Differential Revision: D47710904

fbshipit-source-id: 75a5c795ddcc9058bdc75db27bbc3a6a0ad71ade
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47710904

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jul 26, 2023
Summary:
Pull Request resolved: pytorch#1948

Introduce an abstract class for decoupled acquisition functions.

A decoupled acquisition function where one may intend to evaluate a design on only a subset of the outcomes. Typically this would be handled by fantasizing, where one would fantasize as to what the partial observation would be if one were to evaluate a design on the subset of outcomes (e.g. you only fantasize at those outcomes)

Reviewed By: esantorella

Differential Revision: D47710904

fbshipit-source-id: 2c4cd9c0818467c2fd13c4b02c9a2f68734dc3fb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47710904

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jul 26, 2023
Summary:
Pull Request resolved: pytorch#1948

Introduce an abstract class for decoupled acquisition functions.

A decoupled acquisition function where one may intend to evaluate a design on only a subset of the outcomes. Typically this would be handled by fantasizing, where one would fantasize as to what the partial observation would be if one were to evaluate a design on the subset of outcomes (e.g. you only fantasize at those outcomes)

Differential Revision: https://internalfb.com/D47710904

fbshipit-source-id: b10608b5ab8feaebcb209cab0e6e95f029cf0fbe
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1948 (0d69a21) into main (cca54db) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0d69a21 differs from pull request most recent head abe786a. Consider uploading reports for the commit abe786a to get more accurate results

@@           Coverage Diff           @@
##             main    #1948   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         177      178    +1     
  Lines       15693    15746   +53     
=======================================
+ Hits        15685    15738   +53     
  Misses          8        8           
Files Changed Coverage Δ
botorch/acquisition/__init__.py 100.00% <100.00%> (ø)
botorch/acquisition/decoupled.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jul 26, 2023
Summary:
Pull Request resolved: pytorch#1948

Introduce an abstract class for decoupled acquisition functions.

A decoupled acquisition function where one may intend to evaluate a design on only a subset of the outcomes. Typically this would be handled by fantasizing, where one would fantasize as to what the partial observation would be if one were to evaluate a design on the subset of outcomes (e.g. you only fantasize at those outcomes)

Differential Revision: https://internalfb.com/D47710904

fbshipit-source-id: e31fb21afdca0f65ab96e5d1d124b0eaa815ecb6
Summary:
Pull Request resolved: pytorch#1948

Introduce an abstract class for decoupled acquisition functions.

A decoupled acquisition function where one may intend to evaluate a design on only a subset of the outcomes. Typically this would be handled by fantasizing, where one would fantasize as to what the partial observation would be if one were to evaluate a design on the subset of outcomes (e.g. you only fantasize at those outcomes)

Reviewed By: esantorella

Differential Revision: D47710904

fbshipit-source-id: e61b3555c5fd93b53990ce3af299650bbb5341e1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47710904

sdaulton added a commit to sdaulton/botorch that referenced this pull request Jul 27, 2023
Summary:
Pull Request resolved: pytorch#1948

Introduce an abstract class for decoupled acquisition functions.

A decoupled acquisition function where one may intend to evaluate a design on only a subset of the outcomes. Typically this would be handled by fantasizing, where one would fantasize as to what the partial observation would be if one were to evaluate a design on the subset of outcomes (e.g. you only fantasize at those outcomes)

Differential Revision: https://internalfb.com/D47710904

fbshipit-source-id: 1dbebeaa4fac09a74f25cfc441bef4dcf5fb7d3f
sdaulton added a commit to sdaulton/botorch that referenced this pull request Jul 27, 2023
Summary:
Pull Request resolved: pytorch#1948

Introduce an abstract class for decoupled acquisition functions.

A decoupled acquisition function where one may intend to evaluate a design on only a subset of the outcomes. Typically this would be handled by fantasizing, where one would fantasize as to what the partial observation would be if one were to evaluate a design on the subset of outcomes (e.g. you only fantasize at those outcomes)

Differential Revision: https://internalfb.com/D47710904

fbshipit-source-id: 6fdcc76ada89028cc48c0df5644a93a7c65e73d8
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d346b55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants