fix twisted import structure in botorch.acquisition.utils #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48329866 |
Summary: Pull Request resolved: pytorch#1986 X-link: facebook/Ax#1783 X-link: facebookexternal/botorch_fb#14 See title. This fixes a twisted import structure where botorch.acquisition.monte_carlo imports from utils and utils imports botorch.acquisition.monte_carlo Reviewed By: esantorella Differential Revision: D48329866 fbshipit-source-id: 13f311a196e4ab2cbe88dbddf35a9a926428eae7
|
This pull request was exported from Phabricator. Differential Revision: D48329866 |
sdaulton
force-pushed
the
export-D48329866
branch
from
17d7b46 to
ebbe0ba
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Aug 23, 2023
) Summary: X-link: pytorch/botorch#1986 Pull Request resolved: facebook#1783 X-link: facebookexternal/botorch_fb#14 See title. This fixes a twisted import structure where botorch.acquisition.monte_carlo imports from utils and utils imports botorch.acquisition.monte_carlo Reviewed By: esantorella Differential Revision: D48329866 fbshipit-source-id: 28bea1db6d93c7d25f36ce65a1099d00896135e8
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: pytorch#1986 X-link: facebook/Ax#1783 X-link: facebookexternal/botorch_fb#14 See title. This fixes a twisted import structure where botorch.acquisition.monte_carlo imports from utils and utils imports botorch.acquisition.monte_carlo Differential Revision: https://internalfb.com/D48329866 fbshipit-source-id: d278c76641ce93adf878ea393e204505b8a7ec40
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Aug 24, 2023
Summary: X-link: pytorch/botorch#1986 Pull Request resolved: #1783 X-link: facebookexternal/botorch_fb#14 See title. This fixes a twisted import structure where botorch.acquisition.monte_carlo imports from utils and utils imports botorch.acquisition.monte_carlo Reviewed By: esantorella Differential Revision: D48329866 fbshipit-source-id: 9cd8c146ba579b13a1a0ea265d2354b7a71421a8
|
This pull request has been merged in 31323e5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookexternal/botorch_fb/pull/14
See title. This fixes a twisted import structure where botorch.acquisition.monte_carlo imports from utils and utils imports botorch.acquisition.monte_carlo
Differential Revision: D48329866