Remove file emptied in previous diff #2040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50203838 |
Codecov Report
@@ Coverage Diff @@
## main #2040 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 179 178 -1
Lines 15889 15755 -134
===========================================
- Hits 15889 15752 -137
- Misses 0 3 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request was exported from Phabricator. Differential Revision: D50203838 |
esantorella
force-pushed
the
export-D50203838
branch
from
757f970 to
4a028f8
Compare
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: pytorch#2040 Removes numpy_converter.py. Differential Revision: D50203838 fbshipit-source-id: 4728cc883580dc8b63c6a27a086e5a004418d5b4
|
This pull request was exported from Phabricator. Differential Revision: D50203838 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: pytorch#2040 Removes numpy_converter.py. Differential Revision: D50203838 fbshipit-source-id: 1b8dc1b33b6b5dc258064f3139a42221072080d4
esantorella
force-pushed
the
export-D50203838
branch
from
4a028f8 to
529da5b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50203838 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: pytorch#2040 Removes numpy_converter.py. Reviewed By: saitcakmak Differential Revision: D50203838 fbshipit-source-id: 147ff8bf247d48c79317123313ae7de438b8eb6a
esantorella
force-pushed
the
export-D50203838
branch
from
529da5b to
08bc5a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50203838 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Oct 13, 2023
Summary: Pull Request resolved: pytorch#2040 Removes numpy_converter.py. Reviewed By: saitcakmak Differential Revision: D50203838 fbshipit-source-id: 8c57d6a0f6fed428f1cece8e276aebe7a5f06ba1
esantorella
force-pushed
the
export-D50203838
branch
from
08bc5a2 to
0ae9a56
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50203838 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Oct 13, 2023
Summary: Pull Request resolved: pytorch#2040 Removes numpy_converter.py. Reviewed By: saitcakmak Differential Revision: D50203838 fbshipit-source-id: b9dbe4e7cccc0883df4b79e111690a04c3646abb
esantorella
force-pushed
the
export-D50203838
branch
from
0ae9a56 to
85b2e6e
Compare
…rch (pytorch#1995) Summary: ## Motivation Removes most of what was deprecated in pytorch#1439, in version 0.8.0, except for `_get_extra_mll_args` and `fit_gpytorch_model`. Removal was straightforward since the functionality was not used and relevant unit tests were clearly labeled and self-contained. ### Have you read the [Contributing Guidelines on pull requests](https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md#pull-requests)? Yes Pull Request resolved: pytorch#1995 Pull Request resolved: pytorch#2041 Test Plan: Existing units; make sure codecov has not regressed from deleting tests. ## Related PRs pytorch#1439 Differential Revision: https://internalfb.com/D50276821 fbshipit-source-id: 2c90b1b254a5246160b9848812155de68b2a00ce
Summary: Pull Request resolved: pytorch#2040 Removes numpy_converter.py. Reviewed By: saitcakmak Differential Revision: D50203838 fbshipit-source-id: 56cea489afe9cbea4ff53e0636eeefcefe9828d3
|
This pull request was exported from Phabricator. Differential Revision: D50203838 |
esantorella
force-pushed
the
export-D50203838
branch
from
85b2e6e to
c416ba9
Compare
|
This pull request has been merged in 8413920. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Removes numpy_converter.py.
Differential Revision: D50203838