Delete references to deprecated DeterministicPosterior and DeterministicSampler #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ticSampler, replacing with EnsemblePosterior
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2391 +/- ##
==========================================
- Coverage 99.98% 99.98% -0.01%
==========================================
Files 191 189 -2
Lines 16715 16674 -41
==========================================
- Hits 16712 16671 -41
Misses 3 3 ☔ View full report in Codecov by Sentry. |
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Jul 2, 2024
…ticSampler (pytorch#2391) Summary: ## Motivation Delete references to deprecated DeterministicPosterior and DeterministicSampler, replacing `DeterministicPosterior` with `EnsemblePosterior` where appropriate. These were deprecated before 0.9.0, so now that we are past 0.11.0, they can be reaped. Pull Request resolved: pytorch#2391 Test Plan: Replaced `DeterministicPosterior` with `EnsemblePosterior` in tests ## Related PRs pytorch#1636 Differential Revision: D59057165 Reviewed By: Balandat Pulled By: Balandat
|
@esantorella merged this pull request in ee06209. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
Summary: ## Motivation The CI is broken after merging #2391 and #2409. It passed on the pull requests, but there may have been a Meta-internal change that never got reflected on the OSS CI, and these changes didn't wind up merged. Pull Request resolved: #2410 Test Plan: `sphinx-build -WT --keep-going sphinx/source sphinx/build` no longer errors Reviewed By: Balandat Differential Revision: D59292673 Pulled By: esantorella fbshipit-source-id: d307a8eaf37373c29ff42db75900bebb36e29b79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Delete references to deprecated DeterministicPosterior and DeterministicSampler, replacing
DeterministicPosteriorwithEnsemblePosteriorwhere appropriate. These were deprecated before 0.9.0, so now that we are past 0.11.0, they can be reaped.Test Plan
Replaced
DeterministicPosteriorwithEnsemblePosteriorintestsRelated PRs
#1636