Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builder images to ROCm5.7 #1541

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Update builder images to ROCm5.7 #1541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53fea62
Update docker build images for rocm5.7
jithunnair-amd Sep 17, 2023
5e89be5
Fix erroneous logic that was skipping msccl files even for ROCm5.6; u…
jithunnair-amd Aug 2, 2023
8ef5fc9
missing bzip2 package install for miopen
jeffdaily Sep 18, 2023
8582314
Revert "missing bzip2 package install for miopen"
jeffdaily Sep 18, 2023
25592a7
ROCm 5.7 MIOpen does not need any patches, do not build from source
jeffdaily Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-libtorch-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
runs-on: linux.12xlarge
strategy:
matrix:
rocm_version: ["5.5", "5.6"]
rocm_version: ["5.6", "5.7"]
env:
GPU_ARCH_TYPE: rocm
GPU_ARCH_VERSION: ${{ matrix.rocm_version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-manywheel-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
runs-on: linux.12xlarge
strategy:
matrix:
rocm_version: ["5.5", "5.6"]
rocm_version: ["5.6", "5.7"]
env:
GPU_ARCH_TYPE: rocm
GPU_ARCH_VERSION: ${{ matrix.rocm_version }}
Expand Down
5 changes: 4 additions & 1 deletion common/install_miopen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ MIOPEN_CMAKE_COMMON_FLAGS="
-DMIOPEN_BUILD_DRIVER=OFF
"
# Pull MIOpen repo and set DMIOPEN_EMBED_DB based on ROCm version
if [[ $ROCM_INT -ge 50600 ]] && [[ $ROCM_INT -lt 50700 ]]; then
if [[ $ROCM_INT -ge 50700 ]] && [[ $ROCM_INT -lt 50800 ]]; then
echo "ROCm 5.7 MIOpen does not need any patches, do not build from source"
exit 0
jithunnair-amd marked this conversation as resolved.
Show resolved Hide resolved
elif [[ $ROCM_INT -ge 50600 ]] && [[ $ROCM_INT -lt 50700 ]]; then
MIOPEN_BRANCH="release/rocm-rel-5.6-staging"
elif [[ $ROCM_INT -ge 50500 ]] && [[ $ROCM_INT -lt 50600 ]]; then
MIOPEN_BRANCH="release/rocm-rel-5.5-gfx11"
Expand Down
13 changes: 10 additions & 3 deletions manywheel/build_rocm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,17 @@ if [[ $ROCM_INT -ge 50500 ]]; then

DEPS_AUX_SRCLIST+=(${MIOPEN_SHARE_FILES[@]/#/$MIOPEN_SHARE_SRC/})
DEPS_AUX_DSTLIST+=(${MIOPEN_SHARE_FILES[@]/#/$MIOPEN_SHARE_DST/})
elif [[ $ROCM_INT -ge 50600 ]]; then
fi

if [[ $ROCM_INT -ge 50600 ]]; then
# RCCL library files
RCCL_SHARE_SRC=$ROCM_HOME/lib/msccl-algorithms
RCCL_SHARE_DST=lib/msccl-algorithms
if [[ $ROCM_INT -ge 50700 ]]; then
RCCL_SHARE_SRC=$ROCM_HOME/share/rccl/msccl-algorithms
RCCL_SHARE_DST=share/rccl/msccl-algorithms
else
RCCL_SHARE_SRC=$ROCM_HOME/lib/msccl-algorithms
RCCL_SHARE_DST=lib/msccl-algorithms
fi
RCCL_SHARE_FILES=($(ls $RCCL_SHARE_SRC))

DEPS_AUX_SRCLIST+=(${RCCL_SHARE_FILES[@]/#/$RCCL_SHARE_SRC/})
Expand Down