Windows use mkl static lib. #1790
Merged
+8
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgong5
approved these changes
Apr 24, 2024
malfet
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Ok, let's battle test it, started a re-run in https://github.com/pytorch/pytorch/actions/runs/8812796613/job/24205331140
xuhancn
added a commit
to xuhancn/pytorch_builder
that referenced
this pull request
Apr 24, 2024
This reverts commit 9f33088.
malfet
added a commit
that referenced
this pull request
Apr 24, 2024
This reverts commit 9f33088 as it breaks the build, see https://github.com/pytorch/pytorch/actions/runs/8812796613/job/24205331140
|
@xuhancn reverted, please do not hesitate to open new PR, but this time test it using |
@malfet I don‘t have permittion to submit dummy builder tester PR. |
malfet
pushed a commit
that referenced
this pull request
Apr 26, 2024
resubmit #1790 with fix PR #1797. From pytorch issue: pytorch/pytorch#124009 I found libtorch seems use shared mkl lib and missing some mkl dll files. 1. Currently pytorch Linux already use static mkl lib. 2. Windows can also support static mkl lib, I have validated as pytorch/pytorch#116946 Tested in https://github.com/pytorch/pytorch/actions/runs/8836875904/job/24264643410
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jun 28, 2024
# Background I have fixed pytorch Windows missing mkl shared library dependency issue: #124009 The solution is change torch_cpu module static link mkl library: 1. pytorch static link mkl PR: #124925 2. builder install mkl static library: pytorch/builder#1790 Double confirmed current build is using mkl static link: #124009 (comment) # Goal Remove setup.py `install_requires` will install mkl shared lib on pytorch Windows. It is not required now, due to we have static linked it. It will reduce the pytorch install network traffic and avoid install useless mkl shared library package. Pull Request resolved: #129493 Approved by: https://github.com/malfet
pytorchbot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jun 28, 2024
# Background I have fixed pytorch Windows missing mkl shared library dependency issue: #124009 The solution is change torch_cpu module static link mkl library: 1. pytorch static link mkl PR: #124925 2. builder install mkl static library: pytorch/builder#1790 Double confirmed current build is using mkl static link: #124009 (comment) # Goal Remove setup.py `install_requires` will install mkl shared lib on pytorch Windows. It is not required now, due to we have static linked it. It will reduce the pytorch install network traffic and avoid install useless mkl shared library package. Pull Request resolved: #129493 Approved by: https://github.com/malfet (cherry picked from commit 424068d)
atalman
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jun 28, 2024
[Windows] remove mkl shared library dependency. (#129493) # Background I have fixed pytorch Windows missing mkl shared library dependency issue: #124009 The solution is change torch_cpu module static link mkl library: 1. pytorch static link mkl PR: #124925 2. builder install mkl static library: pytorch/builder#1790 Double confirmed current build is using mkl static link: #124009 (comment) # Goal Remove setup.py `install_requires` will install mkl shared lib on pytorch Windows. It is not required now, due to we have static linked it. It will reduce the pytorch install network traffic and avoid install useless mkl shared library package. Pull Request resolved: #129493 Approved by: https://github.com/malfet (cherry picked from commit 424068d) Co-authored-by: Xu Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From pytorch issue: pytorch/pytorch#124009 I found libtorch seems use shared mkl lib and missing some mkl dll files.
So, this PR will switch pytorch to use static mkl lib.
I have tested PR on my local PC: