Build wheels with debug info #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
changed the title
malfet
approved these changes
May 21, 2021
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 24, 2021
Summary: Pull Request resolved: #58685 This moves debug packages out of the artifacts dir before running tests (as a counterpart to pytorch/builder#770). Doing it this way allows us to keep the CI configs simple since there's one directory to use for artifacts / upload to S3. See #58684 for actual CI signals (the ones on this PR are all cancelled since it depends on the builder branch set in the next PR up the stack) Test Plan: Imported from OSS Reviewed By: nikithamalgifb Differential Revision: D28646995 Pulled By: driazati fbshipit-source-id: 965265861968906770a6e6eeecfe7c9458631b5a
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
…8685) Summary: Pull Request resolved: pytorch#58685 This moves debug packages out of the artifacts dir before running tests (as a counterpart to pytorch/builder#770). Doing it this way allows us to keep the CI configs simple since there's one directory to use for artifacts / upload to S3. See pytorch#58684 for actual CI signals (the ones on this PR are all cancelled since it depends on the builder branch set in the next PR up the stack) Test Plan: Imported from OSS Reviewed By: nikithamalgifb Differential Revision: D28646995 Pulled By: driazati fbshipit-source-id: 965265861968906770a6e6eeecfe7c9458631b5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edits the wheel build to also make
libtorch_cpu.so.dbg(and buildlibtorch_cpuin RelWithDebInfo) as an artifact (similar to what we already do for libtorch builds).NB: This relies on pytorch/pytorch#58685, which needs to land first (that one is a no-op when there is no debug info but this one will break tests without that PR)