Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C++ standard to 17 #1051

Closed
wants to merge 1 commit into from
Closed

Update C++ standard to 17 #1051

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Feb 26, 2023

Following the change in PyTorch core.

pytorch/pytorch@87e4a08

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2023
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejguan Will this impact aws_sdk?

Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. The AWS tests passed.

@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ejguan merged this pull request in 61bd6d1.

@ejguan ejguan added this to the 0.6.0 milestone Feb 27, 2023
@ejguan ejguan mentioned this pull request Feb 27, 2023
10 tasks
NivekT pushed a commit that referenced this pull request Feb 28, 2023
Summary:
Following the change in PyTorch core.

pytorch/pytorch@87e4a08

Pull Request resolved: #1051

Reviewed By: NivekT

Differential Revision: D43629811

Pulled By: ejguan

fbshipit-source-id: 9fb43b055ec5731c5854f69e9902d46764411092
ejguan pushed a commit that referenced this pull request Feb 28, 2023
Summary:
Following the change in PyTorch core.

pytorch/pytorch@87e4a08

Pull Request resolved: #1051

Reviewed By: NivekT

Differential Revision: D43629811

Pulled By: ejguan

fbshipit-source-id: 9fb43b055ec5731c5854f69e9902d46764411092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants