Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding serialization test for all IterDataPipes #275

Closed
wants to merge 7 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Mar 3, 2022

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2022
@NivekT NivekT marked this pull request as draft March 3, 2022 19:49
test/test_serialization.py Show resolved Hide resolved
test/test_serialization.py Show resolved Hide resolved
test/test_serialization.py Show resolved Hide resolved
@NivekT
Copy link
Contributor Author

NivekT commented Mar 3, 2022

Domain CI failures are unrelated

@NivekT NivekT marked this pull request as ready for review March 3, 2022 22:10
@NivekT
Copy link
Contributor Author

NivekT commented Mar 3, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@NivekT NivekT requested review from ejguan and VitalyFedyunin March 3, 2022 22:12
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks awesome. But, I do have a few comments below. Thanks!!

test/test_serialization.py Show resolved Hide resolved
test/test_serialization.py Show resolved Hide resolved
test/test_serialization.py Show resolved Hide resolved
Related to this issue:
* #106

Differential Revision: [D34625707](https://our.internmc.facebook.com/intern/diff/D34625707)

[ghstack-poisoned]
@NivekT
Copy link
Contributor Author

NivekT commented Mar 4, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/57/head branch March 11, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants