Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating README and documentation with latest changes #954

Closed
wants to merge 2 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Jan 19, 2023

Stack from ghstack:

Also fixes #953

Differential Revision: D42621598

NivekT added a commit that referenced this pull request Jan 19, 2023
ghstack-source-id: 7449bcb1c8dccab4fde0deb3f4e4ad2b7c92b3ff
Pull Request resolved: #954
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2023
@NivekT NivekT requested review from ejguan and wenleix January 19, 2023 22:13
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please remove the sanity check #953 (comment)?

README.md Outdated
To understand the basic structure of `DataPipes`, please see [What are DataPipes?](#what-are-datapipes) below, and to
see how `DataPipes` can be practically composed into datasets, please see our [`examples/`](examples/) directory.
On top of `DataPipes`, this library provides a new `DataLoader2` that allows the execution of these data pipelines in
various settings and backends. You can learn more about the new version of `DataLoader2` in our
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

various settings and execution backends (ReadingService)

NivekT added a commit that referenced this pull request Jan 19, 2023
ghstack-source-id: 86a02a807549de75aee4e6832237d2f71bb62471
Pull Request resolved: #954
@NivekT
Copy link
Contributor Author

NivekT commented Jan 19, 2023

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@NivekT merged this pull request in 0d4c0f1.

SvenDS9 pushed a commit to SvenDS9/PytorchData that referenced this pull request Jan 24, 2023
Summary: Pull Request resolved: pytorch#954

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D42621598

Pulled By: NivekT

fbshipit-source-id: 1aef46100798e0a41f80e5c94856f0e2cb121cff
@facebook-github-bot facebook-github-bot deleted the gh/NivekT/103/head branch January 24, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants