[BackendUtils]Convert RuntimeBundle to a class #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfix71
reviewed
Nov 20, 2018
bertmaher
reviewed
Nov 20, 2018
opti-mix
reviewed
Nov 20, 2018
gcatron
force-pushed
the
convert_runtime_bundle_to_object
branch
2 times, most recently
from
31e0f81 to
bb30387
Compare
opti-mix
reviewed
Nov 20, 2018
opti-mix
reviewed
Nov 20, 2018
opti-mix
reviewed
Nov 20, 2018
opti-mix
reviewed
Nov 20, 2018
gcatron
force-pushed
the
convert_runtime_bundle_to_object
branch
from
7983b45 to
c98ecdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Converted RuntimeBundle to a class and added helper methods for getting symbolInfo. Moved RuntimeBundle to BackendUtils. Updated Backends to use new helper methods.
Testing: ninja test and ruh.sh both pass
Documentation: N/A
Fixes #1967