Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move optimizeFunction into the base Backend. #2289

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

nickgg
Copy link
Contributor

@nickgg nickgg commented Jan 22, 2019

Description: Move optimizeFunction from ExecutionEngine into the base Backend so it can be used outside of the EE. This lets us remove some code duplication.
Testing: sanity unittests, shouldn't be any behavoural change.
Documentation:

Copy link
Contributor

@rdzhabarov rdzhabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nickgg nickgg merged commit aa3effc into pytorch:master Jan 23, 2019
@nickgg nickgg deleted the optimizeFunc branch February 5, 2019 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants