Fixes expected behavior when no_dist=True in state_dict_loader.load
#115660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ves are still used in state dict loader
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115660
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a5194d6 with merge base 8885128 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
the
oncall: distributed
wz337
added
topic: bug fixes
wz337
approved these changes
Dec 12, 2023
fegin
approved these changes
Dec 12, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
…d` (pytorch#115660) Fixes expected behavior when `no_dist=True` in `state_dict_loader.load` Fixes pytorch#115591 Pull Request resolved: pytorch#115660 Approved by: https://github.com/wz337, https://github.com/fegin
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…d` (pytorch#115660) Fixes expected behavior when `no_dist=True` in `state_dict_loader.load` Fixes pytorch#115591 Pull Request resolved: pytorch#115660 Approved by: https://github.com/wz337, https://github.com/fegin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes expected behavior when
no_dist=Trueinstate_dict_loader.loadFixes #115591
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225