[torch] fix builds for older pybind #146630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: some versions of pybind we build with don't have `py::set_error`. So just use the underlying python C API. Test Plan: unit tests Differential Revision: D69254629
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146630
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b429756 with merge base 49082f9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
oncall: jit
|
This pull request was exported from Phabricator. Differential Revision: D69254629 |
colin2328
approved these changes
Feb 6, 2025
ngimel
approved these changes
Feb 6, 2025
|
@pytorchbot merge -i (Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally) |
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Tytskiy
pushed a commit
to Tytskiy/pytorch
that referenced
this pull request
Feb 18, 2025
Summary: some versions of pybind we build with don't have `py::set_error`. So just use the underlying python C API. Test Plan: unit tests Differential Revision: D69254629 Pull Request resolved: pytorch#146630 Approved by: https://github.com/colin2328, https://github.com/ngimel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
some versions of pybind we build with don't have
py::set_error.So just use the underlying python C API.
Test Plan: unit tests
Differential Revision: D69254629
cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel