[pytorch][mobile] deprecate the LLVM-based static analyzer #68180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we've open sourced the tracing-based selective build, we can deprecate the op-dependency-graph-based selective build and the static analyzer tool that produces the dependency graph. Differential Revision: [D32358467](https://our.internmc.facebook.com/intern/diff/D32358467/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32358467/)! [ghstack-poisoned]
ljk53
requested review from
driazati,
janeyx99,
seemethere and
zhouzhuojie
as code owners
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ab5a975 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
ljk53
added a commit
that referenced
this pull request
Nov 11, 2021
Since we've open sourced the tracing-based selective build, we can deprecate the op-dependency-graph-based selective build and the static analyzer tool that produces the dependency graph. Differential Revision: [D32358467](https://our.internmc.facebook.com/intern/diff/D32358467/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32358467/)! ghstack-source-id: 143104426 Pull Request resolved: #68180
Since we've open sourced the tracing-based selective build, we can deprecate the op-dependency-graph-based selective build and the static analyzer tool that produces the dependency graph. Differential Revision: [D32358467](https://our.internmc.facebook.com/intern/diff/D32358467/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32358467/)! [ghstack-poisoned]
ljk53
added a commit
that referenced
this pull request
Nov 11, 2021
Pull Request resolved: #68180 Since we've open sourced the tracing-based selective build, we can deprecate the op-dependency-graph-based selective build and the static analyzer tool that produces the dependency graph. ghstack-source-id: 143108377 Differential Revision: [D32358467](https://our.internmc.facebook.com/intern/diff/D32358467/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32358467/)!
iseeyuan
reviewed
Nov 11, 2021
| @@ -26,11 +26,6 @@ retry pip install --pre torch torchvision \ | |||
| # binary, and running forward pass with a real model. | |||
| if [[ "$BUILD_ENVIRONMENT" == *-mobile-custom-build-static* ]]; then | |||
| TEST_CUSTOM_BUILD_STATIC=1 test/mobile/custom_build/build.sh | |||
There was a problem hiding this comment.
Maybe we could change the name later. "TEST_CUSTOM_BUILD_STATIC" looks confusing that we are still doing static selective build? cc @cccclai
There was a problem hiding this comment.
Oh, it may be related to selective build with static dispatch.
There was a problem hiding this comment.
Yes, it's selective build with static dispatch. The static analyzer one is below, called "mobile-custom-build-dynamic", as it's created for dynamic dispatch.
iseeyuan
approved these changes
Nov 11, 2021
| @@ -26,11 +26,6 @@ retry pip install --pre torch torchvision \ | |||
| # binary, and running forward pass with a real model. | |||
| if [[ "$BUILD_ENVIRONMENT" == *-mobile-custom-build-static* ]]; then | |||
| TEST_CUSTOM_BUILD_STATIC=1 test/mobile/custom_build/build.sh | |||
There was a problem hiding this comment.
Oh, it may be related to selective build with static dispatch.
seemethere
approved these changes
Nov 11, 2021
|
This pull request has been merged in 3dc0754. |
desertfire
pushed a commit
that referenced
this pull request
Nov 15, 2021
Summary: Pull Request resolved: #68180 Since we've open sourced the tracing-based selective build, we can deprecate the op-dependency-graph-based selective build and the static analyzer tool that produces the dependency graph. ghstack-source-id: 143108377 Test Plan: CIs Reviewed By: seemethere Differential Revision: D32358467 fbshipit-source-id: c61523706b85a49361416da2230ec1b035b8b99c
desertfire
pushed a commit
that referenced
this pull request
Nov 15, 2021
Summary: Pull Request resolved: #68180 Since we've open sourced the tracing-based selective build, we can deprecate the op-dependency-graph-based selective build and the static analyzer tool that produces the dependency graph. ghstack-source-id: 143108377 Test Plan: CIs Reviewed By: seemethere Differential Revision: D32358467 fbshipit-source-id: c61523706b85a49361416da2230ec1b035b8b99c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Since we've open sourced the tracing-based selective build, we can deprecate the
op-dependency-graph-based selective build and the static analyzer tool that
produces the dependency graph.
Differential Revision: D32358467
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!