[4/5]Testing jit module in flatbuffer in Python. #74387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b382689 (more details on the Dr. CI page):
1 failure not recognized by patterns:
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
facebook-github-bot
added
oncall: jit
|
This pull request was exported from Phabricator. Differential Revision: D34968080 |
iseeyuan
reviewed
Mar 18, 2022
| @@ -824,7 +824,16 @@ def make_relative_rpath_args(path): | |||
| include_dirs=[], | |||
| library_dirs=library_dirs, | |||
| extra_link_args=extra_link_args + main_link_args + make_relative_rpath_args('lib')) | |||
| C_flatbuffer = Extension("torch._C_flatbuffer", | |||
There was a problem hiding this comment.
It's a pretty high-level and user-facing extension. Why not adding _flatbuffer to `torch._C', so we don't have to add a new extension here?
There was a problem hiding this comment.
//caffe2:torch cannot depend on flatbuffer without breaking some downstreams. So the use of flatbuffer features for them is opt-in. Therefore, it has to be separate .so to be generated, and thus different names.
|
This pull request was exported from Phabricator. Differential Revision: D34968080 |
iseeyuan
approved these changes
Mar 23, 2022
|
This pull request was exported from Phabricator. Differential Revision: D34968080 |
|
This pull request was exported from Phabricator. Differential Revision: D34968080 |
Summary: Pull Request resolved: pytorch#74387 Make temporary python bindings for flatbuffer to test ScriptModule save / load. Test Plan: unittest Reviewed By: iseeyuan Differential Revision: D34968080 fbshipit-source-id: 7183f514821573a7543531465f53e115467a9daa
|
This pull request was exported from Phabricator. Differential Revision: D34968080 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
Summary: Pull Request resolved: #74387 Make temporary python bindings for flatbuffer to test ScriptModule save / load. (Note: this ignores all push blocking failures!) Test Plan: unittest Reviewed By: iseeyuan Differential Revision: D34968080 fbshipit-source-id: d23b16abda6e4b7ecf6b1198ed6e00908a3db903
|
Hey @qihqi. |
qihqi
added
release notes: mobile
shahofblah
pushed a commit
that referenced
this pull request
Mar 25, 2022
Summary: Pull Request resolved: #74387 Make temporary python bindings for flatbuffer to test ScriptModule save / load. (Note: this ignores all push blocking failures!) Test Plan: unittest Reviewed By: iseeyuan Differential Revision: D34968080 fbshipit-source-id: d23b16abda6e4b7ecf6b1198ed6e00908a3db903 (cherry picked from commit 5cbbc39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Make temporary python bindings for flatbuffer to test ScriptModule save / load.
Test Plan: unittest
Differential Revision: D34968080