Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding M1 to Ci workflows #2934

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Adding M1 to Ci workflows #2934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bccd1e9
adding new ci for m1
udaij12 Feb 8, 2024
6d3755e
removing python setup
udaij12 Feb 8, 2024
a8feaed
adding python 3.10 setup
udaij12 Feb 8, 2024
cdb28b2
adding python 3.10 setup
udaij12 Feb 8, 2024
ddcee1e
removed sanity test
udaij12 Feb 8, 2024
b10c3c2
adding m1 to normal tests and ci
udaij12 Feb 8, 2024
0060b39
adding m1 to normal tests and ci
udaij12 Feb 8, 2024
541cd7b
add m1 tests to regression
udaij12 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci_cpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,15 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macOS-latest]
os: [ubuntu-20.04, macOS-latest, macos-14]
steps:
- name: Setup Python 3.8
- name: Setup Python for M1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why python 3.10? It'll make releasing the binaries a bit annoying if each platform requires a different python version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github macos-14 does not work with python setup less than 3.10 actions/setup-python#808

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading through that issue it seems like the issue was fixed, mind retriggering with 3.8

if: matrix.os == 'macos-14'
uses: actions/setup-python@v5
with:
python-version: '3.10'
- name: Setup Python for all other OS
if: matrix.os != 'macos-14'
uses: actions/setup-python@v4
with:
python-version: 3.8
Expand Down
14 changes: 10 additions & 4 deletions .github/workflows/regression_tests_cpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,21 @@ concurrency:

jobs:
regression-cpu:
# creates workflows for OS: ubuntu, macOS
# creates workflows for OS: ubuntu, macOS, macOS M1
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macOS-latest]
os: [ubuntu-20.04, macOS-latest, macos-14]
steps:
- name: Setup Python 3.8
uses: actions/setup-python@v3
- name: Setup Python for M1
if: matrix.os == 'macos-14'
uses: actions/setup-python@v5
with:
python-version: '3.10'
- name: Setup Python for all other OS
if: matrix.os != 'macos-14'
uses: actions/setup-python@v4
with:
python-version: 3.8
architecture: x64
Expand Down
Loading