Skip to content

Commit

Permalink
Update on "[Bugfix] Allow non Module in TensorDictModule when method …
Browse files Browse the repository at this point in the history
…is passed"

relax this check as [LLM](https://github.com/vllm-project/vllm/blob/main/vllm/entrypoints/llm.py#L53) in vLLM does not subclass nn.Module




[ghstack-poisoned]
  • Loading branch information
mikaylagawarecki committed Feb 28, 2025
1 parent 58dac01 commit 62b5dc9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tensordict/nn/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -1076,7 +1076,6 @@ def __init__(
f"Typical accepted types are nn.Module or TensorDictModule."
)
else:
breakpoint()
if not (hasattr(module, method) and callable(getattr(module, method))):
raise ValueError(
f"Module {module} does not have a callable method {method}. "
Expand Down

0 comments on commit 62b5dc9

Please sign in to comment.