Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Setup] Parametrize PyTorch version with env variable for local builds #1245

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

dvmazur
Copy link
Contributor

@dvmazur dvmazur commented Mar 2, 2025

Description

Describe your changes in detail.

Sometimes it's needed to install tensordict with a PyTorch version than are poorly parsed by python's dependency resolver. For instance, Nvidia's NVCR containers come with PyTorch versions that don't follow semver guidelines (are missing a dash after patch). This leads to pip install a version of PyTorch from PyPI. It wold be helpful to be able to specify the needed version inside an environment variable.

Motivation and Context

close #1244

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot
Copy link

Hi @dvmazur!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 2, 2025
@vmoens vmoens added the setup label Mar 3, 2025
@vmoens vmoens changed the title Parametrize PyTorch version with env variable for local builds [Setup] Parametrize PyTorch version with env variable for local builds Mar 3, 2025
@dvmazur
Copy link
Contributor Author

dvmazur commented Mar 3, 2025

Hi, @vmoens! Could you help me out with the Benchmark CI. I don't quite understand why it is failing.

@vmoens
Copy link
Contributor

vmoens commented Mar 3, 2025

Hi, @vmoens! Could you help me out with the Benchmark CI. I don't quite understand why it is failing.

Not because of this PR!

@vmoens vmoens merged commit b95c382 into pytorch:main Mar 3, 2025
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants