Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] NestedKey typing issues #640

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[Minor] NestedKey typing issues #640

merged 1 commit into from
Jan 26, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 26, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2024
@vmoens vmoens linked an issue Jan 26, 2024 that may be closed by this pull request
3 tasks
@vmoens vmoens added the documentation Improvements or additions to documentation label Jan 26, 2024
@vmoens vmoens merged commit c72d500 into main Jan 26, 2024
31 of 32 checks passed
@vmoens vmoens deleted the NestedKey-typing branch January 26, 2024 11:41
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 124. Improved: $\large\color{#35bf28}40$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 32.2100μs 15.9749μs 62.5983 KOps/s 57.9393 KOps/s $\textbf{\color{#35bf28}+8.04\%}$
test_plain_set_stack_nested 0.1924ms 0.1430ms 6.9916 KOps/s 6.9327 KOps/s $\color{#35bf28}+0.85\%$
test_plain_set_nested_inplace 65.5520μs 18.3213μs 54.5813 KOps/s 50.9550 KOps/s $\textbf{\color{#35bf28}+7.12\%}$
test_plain_set_stack_nested_inplace 0.3414ms 0.1760ms 5.6817 KOps/s 5.6429 KOps/s $\color{#35bf28}+0.69\%$
test_items 15.2790μs 2.4303μs 411.4689 KOps/s 387.5369 KOps/s $\textbf{\color{#35bf28}+6.18\%}$
test_items_nested 1.3108ms 0.2723ms 3.6727 KOps/s 3.6596 KOps/s $\color{#35bf28}+0.36\%$
test_items_nested_locked 0.4694ms 0.2741ms 3.6486 KOps/s 3.6606 KOps/s $\color{#d91a1a}-0.33\%$
test_items_nested_leaf 0.6394ms 0.1697ms 5.8922 KOps/s 5.9972 KOps/s $\color{#d91a1a}-1.75\%$
test_items_stack_nested 1.9876ms 1.3205ms 757.2662 Ops/s 745.8501 Ops/s $\color{#35bf28}+1.53\%$
test_items_stack_nested_leaf 5.3045ms 1.2150ms 823.0317 Ops/s 835.1609 Ops/s $\color{#d91a1a}-1.45\%$
test_items_stack_nested_locked 2.0019ms 0.8757ms 1.1419 KOps/s 1.1197 KOps/s $\color{#35bf28}+1.99\%$
test_keys 20.2480μs 3.9541μs 252.9036 KOps/s 239.9981 KOps/s $\textbf{\color{#35bf28}+5.38\%}$
test_keys_nested 50.8107ms 0.1549ms 6.4540 KOps/s 6.5650 KOps/s $\color{#d91a1a}-1.69\%$
test_keys_nested_locked 0.2944ms 0.1503ms 6.6543 KOps/s 6.4315 KOps/s $\color{#35bf28}+3.46\%$
test_keys_nested_leaf 0.2394ms 0.1280ms 7.8111 KOps/s 7.4562 KOps/s $\color{#35bf28}+4.76\%$
test_keys_stack_nested 2.0196ms 1.2451ms 803.1759 Ops/s 768.1791 Ops/s $\color{#35bf28}+4.56\%$
test_keys_stack_nested_leaf 1.8633ms 1.2545ms 797.1201 Ops/s 778.9679 Ops/s $\color{#35bf28}+2.33\%$
test_keys_stack_nested_locked 1.4195ms 0.8007ms 1.2489 KOps/s 1.2090 KOps/s $\color{#35bf28}+3.31\%$
test_values 9.1695μs 1.1442μs 873.9666 KOps/s 878.5661 KOps/s $\color{#d91a1a}-0.52\%$
test_values_nested 95.8790μs 51.2368μs 19.5172 KOps/s 19.1503 KOps/s $\color{#35bf28}+1.92\%$
test_values_nested_locked 0.1004ms 50.9551μs 19.6251 KOps/s 19.0282 KOps/s $\color{#35bf28}+3.14\%$
test_values_nested_leaf 0.1999ms 44.9963μs 22.2241 KOps/s 21.5633 KOps/s $\color{#35bf28}+3.06\%$
test_values_stack_nested 1.9457ms 1.0227ms 977.8113 Ops/s 950.3971 Ops/s $\color{#35bf28}+2.88\%$
test_values_stack_nested_leaf 1.8783ms 1.0210ms 979.4206 Ops/s 945.0770 Ops/s $\color{#35bf28}+3.63\%$
test_values_stack_nested_locked 0.7975ms 0.5956ms 1.6790 KOps/s 1.6165 KOps/s $\color{#35bf28}+3.87\%$
test_membership 12.3930μs 1.3361μs 748.4229 KOps/s 729.8338 KOps/s $\color{#35bf28}+2.55\%$
test_membership_nested 42.4280μs 3.4346μs 291.1544 KOps/s 281.8897 KOps/s $\color{#35bf28}+3.29\%$
test_membership_nested_leaf 36.7480μs 3.4536μs 289.5517 KOps/s 279.1519 KOps/s $\color{#35bf28}+3.73\%$
test_membership_stacked_nested 30.9880μs 11.5512μs 86.5710 KOps/s 80.4554 KOps/s $\textbf{\color{#35bf28}+7.60\%}$
test_membership_stacked_nested_leaf 53.1490μs 11.6427μs 85.8907 KOps/s 85.5850 KOps/s $\color{#35bf28}+0.36\%$
test_membership_nested_last 32.3200μs 6.5399μs 152.9082 KOps/s 144.6862 KOps/s $\textbf{\color{#35bf28}+5.68\%}$
test_membership_nested_leaf_last 41.8480μs 6.5501μs 152.6684 KOps/s 144.8161 KOps/s $\textbf{\color{#35bf28}+5.42\%}$
test_membership_stacked_nested_last 0.3306ms 0.1781ms 5.6159 KOps/s 5.6421 KOps/s $\color{#d91a1a}-0.46\%$
test_membership_stacked_nested_leaf_last 64.8230μs 13.4408μs 74.4001 KOps/s 71.5342 KOps/s $\color{#35bf28}+4.01\%$
test_nested_getleaf 36.3660μs 10.4479μs 95.7131 KOps/s 95.6949 KOps/s $\color{#35bf28}+0.02\%$
test_nested_get 48.9510μs 10.1332μs 98.6856 KOps/s 100.4869 KOps/s $\color{#d91a1a}-1.79\%$
test_stacked_getleaf 0.5928ms 0.3939ms 2.5390 KOps/s 2.4318 KOps/s $\color{#35bf28}+4.41\%$
test_stacked_get 0.6505ms 0.3644ms 2.7445 KOps/s 2.6444 KOps/s $\color{#35bf28}+3.79\%$
test_nested_getitemleaf 33.4720μs 11.9235μs 83.8682 KOps/s 82.9939 KOps/s $\color{#35bf28}+1.05\%$
test_nested_getitem 48.8410μs 11.3691μs 87.9577 KOps/s 86.7826 KOps/s $\color{#35bf28}+1.35\%$
test_stacked_getitemleaf 0.7047ms 0.3983ms 2.5109 KOps/s 2.4257 KOps/s $\color{#35bf28}+3.52\%$
test_stacked_getitem 0.6324ms 0.3681ms 2.7170 KOps/s 2.6114 KOps/s $\color{#35bf28}+4.04\%$
test_lock_nested 0.6656ms 0.3272ms 3.0562 KOps/s 2.8668 KOps/s $\textbf{\color{#35bf28}+6.61\%}$
test_lock_stack_nested 78.5761ms 5.3441ms 187.1221 Ops/s 189.3324 Ops/s $\color{#d91a1a}-1.17\%$
test_unlock_nested 0.8238ms 0.3308ms 3.0232 KOps/s 2.5000 KOps/s $\textbf{\color{#35bf28}+20.93\%}$
test_unlock_stack_nested 79.4787ms 5.5270ms 180.9311 Ops/s 177.0202 Ops/s $\color{#35bf28}+2.21\%$
test_flatten_speed 0.4625ms 0.3667ms 2.7268 KOps/s 2.6475 KOps/s $\color{#35bf28}+3.00\%$
test_unflatten_speed 0.7823ms 0.4703ms 2.1261 KOps/s 2.1447 KOps/s $\color{#d91a1a}-0.87\%$
test_common_ops 4.8348ms 0.6324ms 1.5814 KOps/s 1.4002 KOps/s $\textbf{\color{#35bf28}+12.94\%}$
test_creation 31.8690μs 1.8473μs 541.3316 KOps/s 511.1945 KOps/s $\textbf{\color{#35bf28}+5.90\%}$
test_creation_empty 28.7340μs 7.5958μs 131.6515 KOps/s 88.6425 KOps/s $\textbf{\color{#35bf28}+48.52\%}$
test_creation_nested_1 30.9570μs 10.1917μs 98.1191 KOps/s 71.3711 KOps/s $\textbf{\color{#35bf28}+37.48\%}$
test_creation_nested_2 31.5990μs 13.4277μs 74.4732 KOps/s 56.8896 KOps/s $\textbf{\color{#35bf28}+30.91\%}$
test_clone 1.4510ms 12.7787μs 78.2553 KOps/s 75.9932 KOps/s $\color{#35bf28}+2.98\%$
test_getitem[int] 36.1470μs 11.2253μs 89.0848 KOps/s 88.0551 KOps/s $\color{#35bf28}+1.17\%$
test_getitem[slice_int] 55.5230μs 23.1447μs 43.2065 KOps/s 42.1148 KOps/s $\color{#35bf28}+2.59\%$
test_getitem[range] 0.1173ms 39.7807μs 25.1378 KOps/s 24.4131 KOps/s $\color{#35bf28}+2.97\%$
test_getitem[tuple] 61.1140μs 18.0082μs 55.5303 KOps/s 52.8679 KOps/s $\textbf{\color{#35bf28}+5.04\%}$
test_getitem[list] 0.1101ms 35.0857μs 28.5016 KOps/s 27.4681 KOps/s $\color{#35bf28}+3.76\%$
test_setitem_dim[int] 40.1550μs 25.6715μs 38.9537 KOps/s 31.9308 KOps/s $\textbf{\color{#35bf28}+21.99\%}$
test_setitem_dim[slice_int] 0.1330ms 52.6930μs 18.9778 KOps/s 17.0947 KOps/s $\textbf{\color{#35bf28}+11.02\%}$
test_setitem_dim[range] 0.1176ms 68.5151μs 14.5953 KOps/s 12.8918 KOps/s $\textbf{\color{#35bf28}+13.21\%}$
test_setitem_dim[tuple] 72.2940μs 39.9257μs 25.0465 KOps/s 21.0244 KOps/s $\textbf{\color{#35bf28}+19.13\%}$
test_setitem 65.9130μs 18.1184μs 55.1926 KOps/s 49.6941 KOps/s $\textbf{\color{#35bf28}+11.06\%}$
test_set 66.3440μs 17.2197μs 58.0731 KOps/s 50.6075 KOps/s $\textbf{\color{#35bf28}+14.75\%}$
test_set_shared 2.3806ms 0.1383ms 7.2302 KOps/s 7.0516 KOps/s $\color{#35bf28}+2.53\%$
test_update 0.1289ms 18.5870μs 53.8011 KOps/s 43.6057 KOps/s $\textbf{\color{#35bf28}+23.38\%}$
test_update_nested 76.5930μs 26.0566μs 38.3781 KOps/s 33.0051 KOps/s $\textbf{\color{#35bf28}+16.28\%}$
test_set_nested 58.3290μs 19.1688μs 52.1680 KOps/s 46.6718 KOps/s $\textbf{\color{#35bf28}+11.78\%}$
test_set_nested_new 80.8510μs 23.0838μs 43.3204 KOps/s 39.7077 KOps/s $\textbf{\color{#35bf28}+9.10\%}$
test_select 98.7940μs 35.6276μs 28.0682 KOps/s 26.1264 KOps/s $\textbf{\color{#35bf28}+7.43\%}$
test_select_nested 0.1314ms 57.7397μs 17.3191 KOps/s 17.0716 KOps/s $\color{#35bf28}+1.45\%$
test_exclude_nested 0.2221ms 0.1165ms 8.5809 KOps/s 8.1052 KOps/s $\textbf{\color{#35bf28}+5.87\%}$
test_empty[True] 0.8736ms 0.4125ms 2.4241 KOps/s 2.3319 KOps/s $\color{#35bf28}+3.96\%$
test_empty[False] 8.0530μs 1.0352μs 965.9871 KOps/s 976.6104 KOps/s $\color{#d91a1a}-1.09\%$
test_unbind_speed 0.3091ms 0.2413ms 4.1444 KOps/s 4.0796 KOps/s $\color{#35bf28}+1.59\%$
test_unbind_speed_stack0 76.9544ms 3.5270ms 283.5277 Ops/s 302.2018 Ops/s $\textbf{\color{#d91a1a}-6.18\%}$
test_unbind_speed_stack1 30.0160μs 2.0816μs 480.3997 KOps/s 491.1180 KOps/s $\color{#d91a1a}-2.18\%$
test_split 71.9885ms 1.6776ms 596.0851 Ops/s 595.1345 Ops/s $\color{#35bf28}+0.16\%$
test_chunk 1.7108ms 1.4687ms 680.8787 Ops/s 665.6714 Ops/s $\color{#35bf28}+2.28\%$
test_creation[device0] 0.1921ms 99.6457μs 10.0356 KOps/s 10.0192 KOps/s $\color{#35bf28}+0.16\%$
test_creation_from_tensor 3.7311ms 81.0332μs 12.3406 KOps/s 11.9765 KOps/s $\color{#35bf28}+3.04\%$
test_add_one[memmap_tensor0] 0.2396ms 5.2415μs 190.7850 KOps/s 186.5012 KOps/s $\color{#35bf28}+2.30\%$
test_contiguous[memmap_tensor0] 11.4710μs 0.6404μs 1.5616 MOps/s 1.5494 MOps/s $\color{#35bf28}+0.79\%$
test_stack[memmap_tensor0] 56.3050μs 3.4818μs 287.2119 KOps/s 281.3693 KOps/s $\color{#35bf28}+2.08\%$
test_memmaptd_index 0.9267ms 0.2220ms 4.5050 KOps/s 3.7370 KOps/s $\textbf{\color{#35bf28}+20.55\%}$
test_memmaptd_index_astensor 0.6539ms 0.2790ms 3.5846 KOps/s 3.4994 KOps/s $\color{#35bf28}+2.44\%$
test_memmaptd_index_op 0.7953ms 0.5188ms 1.9276 KOps/s 1.7220 KOps/s $\textbf{\color{#35bf28}+11.94\%}$
test_serialize_model 0.1040s 0.1002s 9.9753 Ops/s 9.1193 Ops/s $\textbf{\color{#35bf28}+9.39\%}$
test_serialize_model_pickle 0.4485s 0.3778s 2.6472 Ops/s 2.6439 Ops/s $\color{#35bf28}+0.12\%$
test_serialize_weights 0.1680s 0.1057s 9.4584 Ops/s 9.1377 Ops/s $\color{#35bf28}+3.51\%$
test_serialize_weights_returnearly 0.1979s 0.1286s 7.7737 Ops/s 8.2238 Ops/s $\textbf{\color{#d91a1a}-5.47\%}$
test_serialize_weights_pickle 0.8966s 0.5738s 1.7427 Ops/s 2.3601 Ops/s $\textbf{\color{#d91a1a}-26.16\%}$
test_serialize_weights_filesystem 97.6470ms 90.3329ms 11.0702 Ops/s 10.8717 Ops/s $\color{#35bf28}+1.83\%$
test_serialize_model_filesystem 0.1798s 99.9412ms 10.0059 Ops/s 10.7065 Ops/s $\textbf{\color{#d91a1a}-6.54\%}$
test_reshape_pytree 53.6800μs 22.9717μs 43.5317 KOps/s 42.6585 KOps/s $\color{#35bf28}+2.05\%$
test_reshape_td 65.9230μs 29.5343μs 33.8589 KOps/s 32.8368 KOps/s $\color{#35bf28}+3.11\%$
test_view_pytree 85.0380μs 23.0090μs 43.4612 KOps/s 43.1025 KOps/s $\color{#35bf28}+0.83\%$
test_view_td 80.7700ms 11.5409μs 86.6484 KOps/s 123.6393 KOps/s $\textbf{\color{#d91a1a}-29.92\%}$
test_unbind_pytree 71.5140μs 25.8927μs 38.6210 KOps/s 37.9047 KOps/s $\color{#35bf28}+1.89\%$
test_unbind_td 0.5081ms 35.0816μs 28.5049 KOps/s 27.2992 KOps/s $\color{#35bf28}+4.42\%$
test_split_pytree 56.5250μs 25.7983μs 38.7622 KOps/s 37.4269 KOps/s $\color{#35bf28}+3.57\%$
test_split_td 0.1175ms 40.5448μs 24.6641 KOps/s 24.5922 KOps/s $\color{#35bf28}+0.29\%$
test_add_pytree 78.4260μs 31.4555μs 31.7909 KOps/s 30.7257 KOps/s $\color{#35bf28}+3.47\%$
test_add_td 0.1099ms 44.4273μs 22.5087 KOps/s 18.8034 KOps/s $\textbf{\color{#35bf28}+19.71\%}$
test_distributed 0.1775ms 96.4813μs 10.3647 KOps/s 9.8918 KOps/s $\color{#35bf28}+4.78\%$
test_tdmodule 0.1623ms 20.6459μs 48.4358 KOps/s 42.7553 KOps/s $\textbf{\color{#35bf28}+13.29\%}$
test_tdmodule_dispatch 0.1974ms 39.9398μs 25.0377 KOps/s 21.7805 KOps/s $\textbf{\color{#35bf28}+14.95\%}$
test_tdseq 0.3355ms 23.6592μs 42.2668 KOps/s 35.6634 KOps/s $\textbf{\color{#35bf28}+18.52\%}$
test_tdseq_dispatch 0.1304ms 43.2076μs 23.1441 KOps/s 19.9651 KOps/s $\textbf{\color{#35bf28}+15.92\%}$
test_instantiation_functorch 1.4996ms 1.2902ms 775.0754 Ops/s 738.3428 Ops/s $\color{#35bf28}+4.97\%$
test_instantiation_td 1.4760ms 0.9931ms 1.0069 KOps/s 953.9995 Ops/s $\textbf{\color{#35bf28}+5.55\%}$
test_exec_functorch 0.2682ms 0.1528ms 6.5438 KOps/s 6.3293 KOps/s $\color{#35bf28}+3.39\%$
test_exec_functional_call 0.3062ms 0.1447ms 6.9108 KOps/s 6.7642 KOps/s $\color{#35bf28}+2.17\%$
test_exec_td 0.2829ms 0.1423ms 7.0270 KOps/s 6.8676 KOps/s $\color{#35bf28}+2.32\%$
test_exec_td_decorator 0.5595ms 0.1767ms 5.6586 KOps/s 5.5145 KOps/s $\color{#35bf28}+2.61\%$
test_vmap_mlp_speed[True-True] 1.2032ms 0.8706ms 1.1487 KOps/s 1.0886 KOps/s $\textbf{\color{#35bf28}+5.51\%}$
test_vmap_mlp_speed[True-False] 0.7255ms 0.4556ms 2.1948 KOps/s 2.0561 KOps/s $\textbf{\color{#35bf28}+6.75\%}$
test_vmap_mlp_speed[False-True] 1.1059ms 0.7698ms 1.2991 KOps/s 1.2516 KOps/s $\color{#35bf28}+3.80\%$
test_vmap_mlp_speed[False-False] 0.6036ms 0.3776ms 2.6480 KOps/s 2.5479 KOps/s $\color{#35bf28}+3.93\%$
test_vmap_mlp_speed_decorator[True-True] 2.7331ms 2.2124ms 452.0064 Ops/s 421.8433 Ops/s $\textbf{\color{#35bf28}+7.15\%}$
test_vmap_mlp_speed_decorator[True-False] 1.1249ms 0.5221ms 1.9153 KOps/s 1.8678 KOps/s $\color{#35bf28}+2.54\%$
test_vmap_mlp_speed_decorator[False-True] 2.3769ms 1.8130ms 551.5862 Ops/s 515.3492 Ops/s $\textbf{\color{#35bf28}+7.03\%}$
test_vmap_mlp_speed_decorator[False-False] 0.7556ms 0.3969ms 2.5196 KOps/s 2.4363 KOps/s $\color{#35bf28}+3.42\%$

Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 132. Improved: $\large\color{#35bf28}13$. Worsened: $\large\color{#d91a1a}22$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 60.6778ms 17.4468μs 57.3172 KOps/s 78.9046 KOps/s $\textbf{\color{#d91a1a}-27.36\%}$
test_plain_set_stack_nested 0.1511ms 0.1201ms 8.3284 KOps/s 8.3749 KOps/s $\color{#d91a1a}-0.56\%$
test_plain_set_nested_inplace 43.4710μs 15.8523μs 63.0823 KOps/s 71.0513 KOps/s $\textbf{\color{#d91a1a}-11.22\%}$
test_plain_set_stack_nested_inplace 0.1893ms 0.1500ms 6.6669 KOps/s 6.6835 KOps/s $\color{#d91a1a}-0.25\%$
test_items 18.1810μs 4.8132μs 207.7621 KOps/s 208.6764 KOps/s $\color{#d91a1a}-0.44\%$
test_items_nested 0.3754ms 0.3420ms 2.9237 KOps/s 2.9220 KOps/s $\color{#35bf28}+0.06\%$
test_items_nested_locked 0.3650ms 0.3448ms 2.9003 KOps/s 2.8992 KOps/s $\color{#35bf28}+0.04\%$
test_items_nested_leaf 0.2337ms 0.2019ms 4.9540 KOps/s 4.9483 KOps/s $\color{#35bf28}+0.12\%$
test_items_stack_nested 1.6024ms 1.3318ms 750.8433 Ops/s 740.7688 Ops/s $\color{#35bf28}+1.36\%$
test_items_stack_nested_leaf 1.2325ms 1.1771ms 849.5660 Ops/s 853.2206 Ops/s $\color{#d91a1a}-0.43\%$
test_items_stack_nested_locked 1.9754ms 0.9257ms 1.0802 KOps/s 1.0636 KOps/s $\color{#35bf28}+1.56\%$
test_keys 22.9400μs 4.6200μs 216.4494 KOps/s 216.9320 KOps/s $\color{#d91a1a}-0.22\%$
test_keys_nested 0.5574ms 95.1745μs 10.5070 KOps/s 10.4362 KOps/s $\color{#35bf28}+0.68\%$
test_keys_nested_locked 0.1208ms 99.0323μs 10.0977 KOps/s 10.0725 KOps/s $\color{#35bf28}+0.25\%$
test_keys_nested_leaf 0.1812ms 79.0389μs 12.6520 KOps/s 12.5482 KOps/s $\color{#35bf28}+0.83\%$
test_keys_stack_nested 1.2251ms 1.1681ms 856.0658 Ops/s 831.2149 Ops/s $\color{#35bf28}+2.99\%$
test_keys_stack_nested_leaf 1.2008ms 1.1539ms 866.6175 Ops/s 850.9324 Ops/s $\color{#35bf28}+1.84\%$
test_keys_stack_nested_locked 0.8301ms 0.7486ms 1.3359 KOps/s 1.3140 KOps/s $\color{#35bf28}+1.66\%$
test_values 9.0400μs 1.9070μs 524.3835 KOps/s 523.0925 KOps/s $\color{#35bf28}+0.25\%$
test_values_nested 69.7320μs 45.9440μs 21.7656 KOps/s 21.4898 KOps/s $\color{#35bf28}+1.28\%$
test_values_nested_locked 70.4010μs 48.0933μs 20.7929 KOps/s 20.6847 KOps/s $\color{#35bf28}+0.52\%$
test_values_nested_leaf 0.1004ms 39.6012μs 25.2518 KOps/s 24.9639 KOps/s $\color{#35bf28}+1.15\%$
test_values_stack_nested 1.0515ms 0.9881ms 1.0120 KOps/s 1.0181 KOps/s $\color{#d91a1a}-0.59\%$
test_values_stack_nested_leaf 1.1139ms 0.9823ms 1.0180 KOps/s 1.0221 KOps/s $\color{#d91a1a}-0.40\%$
test_values_stack_nested_locked 0.6899ms 0.6223ms 1.6070 KOps/s 1.6602 KOps/s $\color{#d91a1a}-3.20\%$
test_membership 13.3162μs 0.9359μs 1.0685 MOps/s 1.0438 MOps/s $\color{#35bf28}+2.36\%$
test_membership_nested 33.4900μs 2.9053μs 344.1990 KOps/s 343.3473 KOps/s $\color{#35bf28}+0.25\%$
test_membership_nested_leaf 44.8300μs 2.9175μs 342.7641 KOps/s 340.9273 KOps/s $\color{#35bf28}+0.54\%$
test_membership_stacked_nested 36.0500μs 11.5852μs 86.3169 KOps/s 84.9317 KOps/s $\color{#35bf28}+1.63\%$
test_membership_stacked_nested_leaf 46.4910μs 11.5488μs 86.5891 KOps/s 85.3422 KOps/s $\color{#35bf28}+1.46\%$
test_membership_nested_last 21.6510μs 5.3414μs 187.2170 KOps/s 187.8545 KOps/s $\color{#d91a1a}-0.34\%$
test_membership_nested_leaf_last 34.9510μs 5.3732μs 186.1072 KOps/s 187.0544 KOps/s $\color{#d91a1a}-0.51\%$
test_membership_stacked_nested_last 0.1871ms 0.1565ms 6.3881 KOps/s 6.3817 KOps/s $\color{#35bf28}+0.10\%$
test_membership_stacked_nested_leaf_last 30.8600μs 13.4591μs 74.2989 KOps/s 74.1898 KOps/s $\color{#35bf28}+0.15\%$
test_nested_getleaf 42.4300μs 8.4040μs 118.9906 KOps/s 118.5136 KOps/s $\color{#35bf28}+0.40\%$
test_nested_get 31.1100μs 7.9288μs 126.1225 KOps/s 125.3888 KOps/s $\color{#35bf28}+0.59\%$
test_stacked_getleaf 0.3684ms 0.3344ms 2.9905 KOps/s 3.0230 KOps/s $\color{#d91a1a}-1.07\%$
test_stacked_get 0.3765ms 0.2965ms 3.3727 KOps/s 3.3544 KOps/s $\color{#35bf28}+0.55\%$
test_nested_getitemleaf 26.9610μs 9.8116μs 101.9202 KOps/s 101.3646 KOps/s $\color{#35bf28}+0.55\%$
test_nested_getitem 32.4400μs 9.4180μs 106.1800 KOps/s 106.3524 KOps/s $\color{#d91a1a}-0.16\%$
test_stacked_getitemleaf 0.3986ms 0.3486ms 2.8687 KOps/s 2.9775 KOps/s $\color{#d91a1a}-3.65\%$
test_stacked_getitem 0.3532ms 0.3015ms 3.3171 KOps/s 3.3197 KOps/s $\color{#d91a1a}-0.08\%$
test_lock_nested 0.7550ms 0.3574ms 2.7983 KOps/s 2.7531 KOps/s $\color{#35bf28}+1.64\%$
test_lock_stack_nested 86.0814ms 6.3457ms 157.5863 Ops/s 156.2978 Ops/s $\color{#35bf28}+0.82\%$
test_unlock_nested 80.4895ms 0.4387ms 2.2796 KOps/s 2.8112 KOps/s $\textbf{\color{#d91a1a}-18.91\%}$
test_unlock_stack_nested 87.1323ms 6.4391ms 155.3016 Ops/s 152.7184 Ops/s $\color{#35bf28}+1.69\%$
test_flatten_speed 0.6346ms 0.2618ms 3.8191 KOps/s 3.8292 KOps/s $\color{#d91a1a}-0.26\%$
test_unflatten_speed 0.4004ms 0.3642ms 2.7460 KOps/s 2.7989 KOps/s $\color{#d91a1a}-1.89\%$
test_common_ops 1.1192ms 0.6635ms 1.5072 KOps/s 1.7049 KOps/s $\textbf{\color{#d91a1a}-11.60\%}$
test_creation 34.7410μs 1.5461μs 646.7760 KOps/s 631.7217 KOps/s $\color{#35bf28}+2.38\%$
test_creation_empty 40.5700μs 10.2553μs 97.5107 KOps/s 154.9448 KOps/s $\textbf{\color{#d91a1a}-37.07\%}$
test_creation_nested_1 26.8610μs 11.9585μs 83.6225 KOps/s 121.7626 KOps/s $\textbf{\color{#d91a1a}-31.32\%}$
test_creation_nested_2 37.2400μs 14.3167μs 69.8485 KOps/s 93.1691 KOps/s $\textbf{\color{#d91a1a}-25.03\%}$
test_clone 64.5410μs 14.6902μs 68.0726 KOps/s 66.6083 KOps/s $\color{#35bf28}+2.20\%$
test_getitem[int] 26.7600μs 11.3330μs 88.2382 KOps/s 88.9072 KOps/s $\color{#d91a1a}-0.75\%$
test_getitem[slice_int] 42.5510μs 22.0591μs 45.3328 KOps/s 45.9336 KOps/s $\color{#d91a1a}-1.31\%$
test_getitem[range] 0.1832ms 39.0819μs 25.5873 KOps/s 25.3329 KOps/s $\color{#35bf28}+1.00\%$
test_getitem[tuple] 47.3210μs 19.7947μs 50.5186 KOps/s 51.4360 KOps/s $\color{#d91a1a}-1.78\%$
test_getitem[list] 0.1915ms 35.0630μs 28.5201 KOps/s 27.9459 KOps/s $\color{#35bf28}+2.05\%$
test_setitem_dim[int] 48.7410μs 31.1075μs 32.1466 KOps/s 36.6199 KOps/s $\textbf{\color{#d91a1a}-12.22\%}$
test_setitem_dim[slice_int] 68.8610μs 52.1607μs 19.1715 KOps/s 20.5205 KOps/s $\textbf{\color{#d91a1a}-6.57\%}$
test_setitem_dim[range] 83.7010μs 65.5873μs 15.2469 KOps/s 16.0768 KOps/s $\textbf{\color{#d91a1a}-5.16\%}$
test_setitem_dim[tuple] 62.7610μs 45.5851μs 21.9370 KOps/s 23.4380 KOps/s $\textbf{\color{#d91a1a}-6.40\%}$
test_setitem 67.4510μs 20.6185μs 48.5002 KOps/s 52.6394 KOps/s $\textbf{\color{#d91a1a}-7.86\%}$
test_set 82.3710μs 19.9561μs 50.1100 KOps/s 54.5641 KOps/s $\textbf{\color{#d91a1a}-8.16\%}$
test_set_shared 2.9148ms 0.1071ms 9.3398 KOps/s 9.2624 KOps/s $\color{#35bf28}+0.84\%$
test_update 71.1620μs 23.6251μs 42.3278 KOps/s 50.7069 KOps/s $\textbf{\color{#d91a1a}-16.52\%}$
test_update_nested 84.5810μs 30.1582μs 33.1585 KOps/s 38.5081 KOps/s $\textbf{\color{#d91a1a}-13.89\%}$
test_set_nested 57.2810μs 21.3937μs 46.7427 KOps/s 51.1161 KOps/s $\textbf{\color{#d91a1a}-8.56\%}$
test_set_nested_new 67.4010μs 24.1743μs 41.3662 KOps/s 45.5096 KOps/s $\textbf{\color{#d91a1a}-9.10\%}$
test_select 87.9320μs 36.5853μs 27.3334 KOps/s 28.6944 KOps/s $\color{#d91a1a}-4.74\%$
test_select_nested 75.4610μs 53.6447μs 18.6412 KOps/s 18.3680 KOps/s $\color{#35bf28}+1.49\%$
test_exclude_nested 0.1380ms 0.1139ms 8.7823 KOps/s 8.7420 KOps/s $\color{#35bf28}+0.46\%$
test_empty[True] 0.4241ms 0.3872ms 2.5827 KOps/s 2.5655 KOps/s $\color{#35bf28}+0.67\%$
test_empty[False] 2.9101μs 0.8493μs 1.1775 MOps/s 1.1639 MOps/s $\color{#35bf28}+1.16\%$
test_to 73.2320μs 52.4870μs 19.0523 KOps/s 18.0815 KOps/s $\textbf{\color{#35bf28}+5.37\%}$
test_to_nonblocking 66.3210μs 37.0962μs 26.9570 KOps/s 25.8972 KOps/s $\color{#35bf28}+4.09\%$
test_unbind_speed 0.3132ms 0.2726ms 3.6681 KOps/s 3.4678 KOps/s $\textbf{\color{#35bf28}+5.78\%}$
test_unbind_speed_stack0 87.9617ms 4.2094ms 237.5649 Ops/s 230.3393 Ops/s $\color{#35bf28}+3.14\%$
test_unbind_speed_stack1 29.4310μs 1.8909μs 528.8519 KOps/s 539.6068 KOps/s $\color{#d91a1a}-1.99\%$
test_split 2.2620ms 1.5776ms 633.8777 Ops/s 626.8956 Ops/s $\color{#35bf28}+1.11\%$
test_chunk 81.2829ms 1.6971ms 589.2462 Ops/s 583.9883 Ops/s $\color{#35bf28}+0.90\%$
test_creation[device0] 0.1360ms 74.7549μs 13.3771 KOps/s 12.3577 KOps/s $\textbf{\color{#35bf28}+8.25\%}$
test_creation_from_tensor 0.1306ms 58.8539μs 16.9912 KOps/s 16.4629 KOps/s $\color{#35bf28}+3.21\%$
test_add_one[memmap_tensor0] 0.2612ms 8.1363μs 122.9053 KOps/s 115.6107 KOps/s $\textbf{\color{#35bf28}+6.31\%}$
test_contiguous[memmap_tensor0] 26.5210μs 0.6315μs 1.5835 MOps/s 1.5010 MOps/s $\textbf{\color{#35bf28}+5.49\%}$
test_stack[memmap_tensor0] 38.4710μs 4.7057μs 212.5076 KOps/s 184.0282 KOps/s $\textbf{\color{#35bf28}+15.48\%}$
test_memmaptd_index 1.1562ms 0.2763ms 3.6188 KOps/s 3.4290 KOps/s $\textbf{\color{#35bf28}+5.53\%}$
test_memmaptd_index_astensor 0.5914ms 0.3311ms 3.0198 KOps/s 2.9116 KOps/s $\color{#35bf28}+3.72\%$
test_memmaptd_index_op 1.0672ms 0.6808ms 1.4689 KOps/s 1.5103 KOps/s $\color{#d91a1a}-2.74\%$
test_serialize_model 0.1740s 98.4235ms 10.1602 Ops/s 9.2145 Ops/s $\textbf{\color{#35bf28}+10.26\%}$
test_serialize_model_pickle 1.3499s 1.2364s 0.8088 Ops/s 0.8080 Ops/s $\color{#35bf28}+0.09\%$
test_serialize_weights 0.1729s 96.7107ms 10.3401 Ops/s 9.6934 Ops/s $\textbf{\color{#35bf28}+6.67\%}$
test_serialize_weights_returnearly 0.2493s 82.5175ms 12.1186 Ops/s 14.0290 Ops/s $\textbf{\color{#d91a1a}-13.62\%}$
test_serialize_weights_pickle 1.4045s 1.2470s 0.8019 Ops/s 0.8032 Ops/s $\color{#d91a1a}-0.16\%$
test_reshape_pytree 46.5510μs 25.1921μs 39.6949 KOps/s 38.7220 KOps/s $\color{#35bf28}+2.51\%$
test_reshape_td 52.2210μs 29.9967μs 33.3370 KOps/s 33.9293 KOps/s $\color{#d91a1a}-1.75\%$
test_view_pytree 56.2310μs 24.7199μs 40.4532 KOps/s 39.1492 KOps/s $\color{#35bf28}+3.33\%$
test_view_td 0.5660ms 7.0132μs 142.5881 KOps/s 100.6574 KOps/s $\textbf{\color{#35bf28}+41.66\%}$
test_unbind_pytree 73.2820μs 31.1090μs 32.1450 KOps/s 31.7309 KOps/s $\color{#35bf28}+1.30\%$
test_unbind_td 75.2510μs 40.9612μs 24.4134 KOps/s 24.3890 KOps/s $\color{#35bf28}+0.10\%$
test_split_pytree 79.2520μs 29.5350μs 33.8581 KOps/s 32.9814 KOps/s $\color{#35bf28}+2.66\%$
test_split_td 0.1101ms 40.8782μs 24.4629 KOps/s 24.6572 KOps/s $\color{#d91a1a}-0.79\%$
test_add_pytree 73.9310μs 38.2347μs 26.1542 KOps/s 23.8506 KOps/s $\textbf{\color{#35bf28}+9.66\%}$
test_add_td 78.2210μs 52.9414μs 18.8888 KOps/s 19.3266 KOps/s $\color{#d91a1a}-2.27\%$
test_distributed 2.7069ms 83.4591μs 11.9819 KOps/s 10.0387 KOps/s $\textbf{\color{#35bf28}+19.36\%}$
test_tdmodule 34.3210μs 19.0848μs 52.3976 KOps/s 58.5771 KOps/s $\textbf{\color{#d91a1a}-10.55\%}$
test_tdmodule_dispatch 0.2435ms 39.4181μs 25.3690 KOps/s 28.0644 KOps/s $\textbf{\color{#d91a1a}-9.60\%}$
test_tdseq 37.4410μs 21.9692μs 45.5183 KOps/s 51.1650 KOps/s $\textbf{\color{#d91a1a}-11.04\%}$
test_tdseq_dispatch 65.1710μs 42.0316μs 23.7916 KOps/s 27.4146 KOps/s $\textbf{\color{#d91a1a}-13.22\%}$
test_instantiation_functorch 1.8441ms 1.7076ms 585.6173 Ops/s 581.9986 Ops/s $\color{#35bf28}+0.62\%$
test_instantiation_td 1.7157ms 1.1795ms 847.8487 Ops/s 841.1397 Ops/s $\color{#35bf28}+0.80\%$
test_exec_functorch 0.1999ms 0.1654ms 6.0476 KOps/s 5.9358 KOps/s $\color{#35bf28}+1.88\%$
test_exec_functional_call 0.2445ms 0.1668ms 5.9951 KOps/s 5.9176 KOps/s $\color{#35bf28}+1.31\%$
test_exec_td 0.1952ms 0.1579ms 6.3323 KOps/s 6.2026 KOps/s $\color{#35bf28}+2.09\%$
test_exec_td_decorator 0.5953ms 0.1957ms 5.1101 KOps/s 5.0712 KOps/s $\color{#35bf28}+0.77\%$
test_vmap_mlp_speed[True-True] 1.2300ms 1.0704ms 934.2584 Ops/s 939.7538 Ops/s $\color{#d91a1a}-0.58\%$
test_vmap_mlp_speed[True-False] 0.8669ms 0.6157ms 1.6241 KOps/s 1.6430 KOps/s $\color{#d91a1a}-1.15\%$
test_vmap_mlp_speed[False-True] 1.0437ms 0.9820ms 1.0183 KOps/s 1.0156 KOps/s $\color{#35bf28}+0.27\%$
test_vmap_mlp_speed[False-False] 0.6813ms 0.5454ms 1.8336 KOps/s 1.8407 KOps/s $\color{#d91a1a}-0.39\%$
test_vmap_mlp_speed_decorator[True-True] 2.9185ms 2.4694ms 404.9584 Ops/s 423.8940 Ops/s $\color{#d91a1a}-4.47\%$
test_vmap_mlp_speed_decorator[True-False] 1.1461ms 0.6665ms 1.5003 KOps/s 1.5132 KOps/s $\color{#d91a1a}-0.85\%$
test_vmap_mlp_speed_decorator[False-True] 2.4403ms 2.0446ms 489.1043 Ops/s 503.8976 Ops/s $\color{#d91a1a}-2.94\%$
test_vmap_mlp_speed_decorator[False-False] 0.8844ms 0.5588ms 1.7896 KOps/s 1.7185 KOps/s $\color{#35bf28}+4.13\%$
test_vmap_transformer_speed[True-True] 12.6343ms 12.5202ms 79.8708 Ops/s 79.5129 Ops/s $\color{#35bf28}+0.45\%$
test_vmap_transformer_speed[True-False] 8.6514ms 8.2521ms 121.1818 Ops/s 121.6315 Ops/s $\color{#d91a1a}-0.37\%$
test_vmap_transformer_speed[False-True] 13.5524ms 12.5201ms 79.8717 Ops/s 80.2090 Ops/s $\color{#d91a1a}-0.42\%$
test_vmap_transformer_speed[False-False] 8.2420ms 8.1250ms 123.0773 Ops/s 122.5913 Ops/s $\color{#35bf28}+0.40\%$
test_vmap_transformer_speed_decorator[True-True] 77.9158ms 76.2785ms 13.1099 Ops/s 13.4909 Ops/s $\color{#d91a1a}-2.82\%$
test_vmap_transformer_speed_decorator[True-False] 21.2075ms 19.6991ms 50.7638 Ops/s 50.6712 Ops/s $\color{#35bf28}+0.18\%$
test_vmap_transformer_speed_decorator[False-True] 70.1120ms 68.6852ms 14.5592 Ops/s 13.4103 Ops/s $\textbf{\color{#35bf28}+8.57\%}$
test_vmap_transformer_speed_decorator[False-False] 20.9997ms 19.3440ms 51.6956 Ops/s 51.6373 Ops/s $\color{#35bf28}+0.11\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Minor] Typing of key should be NestedKey rather than str?
2 participants