Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STSB and WikiTexts tests #1737

Merged
merged 3 commits into from
May 23, 2022
Merged

Conversation

parmeet
Copy link
Contributor

@parmeet parmeet commented May 23, 2022

This PR fixes issues with STSB and WikiTexts mocked testing. In both the cases mocked files were not written properly in their respective destinations.

fixes #1735

cc: @Nayef211 , @VirgileHlav , @VitalyFedyunin

@parmeet parmeet requested a review from vcm2114 May 23, 2022 16:34
@parmeet parmeet requested review from Nayef211 and vcm2114 and removed request for vcm2114 May 23, 2022 16:34
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for fixing the tests!

test/datasets/test_wikitexts.py Outdated Show resolved Hide resolved
@Nayef211
Copy link
Contributor

I wonder why the build is segfaulting when running python setup.py clean?

@parmeet parmeet merged commit 8bbb6ac into pytorch:main May 23, 2022
@parmeet parmeet deleted the fix_inconsistent_cache branch May 23, 2022 20:00
@parmeet
Copy link
Contributor Author

parmeet commented May 24, 2022

I wonder why the build is segfaulting when running python setup.py clean?

Ya, I am not so sure. I see same issues on audio CI (cc: @mthrok).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching results of the filter will result to inconsistent cache state
3 participants