fix cmake version, padding for a8w4dq, lint... #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
added 2 commits
May 4, 2024 21:26
cbilgin
approved these changes
May 5, 2024
This was referenced May 5, 2024
|
For the PR that adds 257 lines of code, it would be nice to have a bit more description. |
malfet
reviewed
May 6, 2024
Comment on lines
+87
to
+109
| # | ||
| # | ||
| # class Int8DynActInt4WeightQuantizer(QuantHandler): | ||
| # def __init__(self, model: nn.Module, device="cpu", tokenizer=None, **kwargs): | ||
| # import torchao.quantization.quant_api as quant_api | ||
| # | ||
| # self.model_ = model | ||
| # self.device = device | ||
| # self.tokenizer = tokenizer | ||
| # self.quantizer = quant_api.Int8DynActInt4WeightQuantizer( | ||
| # **kwargs, precision=get_precision(), scales_precision=get_precision() | ||
| # ) | ||
| # | ||
| # def create_quantized_state_dict(self) -> Dict: # "StateDict" | ||
| # pass | ||
| # | ||
| # def convert_for_runtime(self) -> nn.Module: | ||
| # pass | ||
| # | ||
| # def quantized_model(self) -> nn.Module: | ||
| # return self.quantizer.quantize(self.model_) | ||
| # | ||
| # |
There was a problem hiding this comment.
Why are we leaving commented out code here?
There was a problem hiding this comment.
Yes, I was planning to do a follow-up PR to remove this
malfet
reviewed
May 6, 2024
| @@ -22,7 +22,7 @@ blobfile | |||
|
|
|||
| # Build tools | |||
| wheel | |||
| cmake | |||
| cmake>=3.24 | |||
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* fix cmake version, p[adding for a8w4dq, lint... * fix cmake version, p[adding for a8w4dq, lint... * updates * fix
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* fix cmake version, p[adding for a8w4dq, lint... * fix cmake version, p[adding for a8w4dq, lint... * updates * fix
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* fix cmake version, p[adding for a8w4dq, lint... * fix cmake version, p[adding for a8w4dq, lint... * updates * fix
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* fix cmake version, p[adding for a8w4dq, lint... * fix cmake version, p[adding for a8w4dq, lint... * updates * fix
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* fix cmake version, p[adding for a8w4dq, lint... * fix cmake version, p[adding for a8w4dq, lint... * updates * fix
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* fix cmake version, p[adding for a8w4dq, lint... * fix cmake version, p[adding for a8w4dq, lint... * updates * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix cmake version, padding for a8w4dq, lint...