Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip standalone git submodule calls and the commit history for ExecuT… #690

Closed
wants to merge 4 commits into from
Closed

Skip standalone git submodule calls and the commit history for ExecuT… #690

wants to merge 4 commits into from

Conversation

shoumikhin
Copy link
Contributor

…orch submodules

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 6, 2024
orionr
orionr requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the README update here? Also, tests are failing...?

README.md
@@ -43,7 +43,7 @@ The following steps require that you have [Python 3.10](https://www.python.org/d
[skip default]: begin
```bash
# get the code
git clone https://github.com/pytorch/torchchat.git
git clone https://github.com/pytorch/torchchat.git --recurse-submodules --shallow-submodules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have any submodules for torchchat, so likely don't need this? Instead, we're using pins to checkout with the shell script?

scripts/install_utils.sh
@@ -25,12 +25,9 @@ clone_executorch() {
rm -rf ${TORCHCHAT_ROOT}/${ET_BUILD_DIR}
mkdir -p ${TORCHCHAT_ROOT}/${ET_BUILD_DIR}/src
pushd ${TORCHCHAT_ROOT}/${ET_BUILD_DIR}/src
git clone https://github.com/pytorch/executorch.git
git clone https://github.com/pytorch/executorch.git --recurse-submodules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely like this one!

@orionr
Copy link
Contributor

orionr commented May 7, 2024 •
edited
Loading

I like this idea, but might also be mostly fixed by @mergennachin removing PyTorch as a submodule for ExecuTroch?

@mikekgfb
Copy link
Contributor

We have a build script for executorch -- can we just use that? Something like

TORCHCHAT_ROOT=${PWD} ./scripts/install_et.sh

@mikekgfb
Copy link
Contributor

mikekgfb commented May 12, 2024 •
edited
Loading

In any event, this is a net improvement over the status quo, and let's not let the perfect be the enemy of better.
Discussed with @shoumikhin and documented as #754 for future action.

Thanks for the improvements and all your work to build this amazing app as a proof point for ExecuTorch and torchchat capabilities

@Jack-Khuu
Copy link
Contributor

Closing old PRs to increase attention of new PRs

@Jack-Khuu Jack-Khuu closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orionr orionr orionr requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shoumikhin @orionr @mikekgfb @Jack-Khuu @facebook-github-bot