Change how TorchFT manages user_state_dict #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR closes some state_dict gaps when integrating with TorchTitan: 1. User state_dict() and load_state_dict() functions can be initialized lazily. 2. Change weights_only to False for torch.load as we may have to load some non-tensor states.
facebook-github-bot
added
the
CLA Signed
c-p-i-o
reviewed
Jan 29, 2025
torchft/checkpointing.py
Outdated
| @@ -172,7 +172,9 @@ def load_from_address(cls, address: str, timeout: timedelta) -> T: | |||
| data = f.read() | |||
|
|
|||
| reader = io.BytesIO(data) | |||
| return torch.load(reader, weights_only=True) | |||
| # We have to set weights_only to True as there are some non-tensor | |||
There was a problem hiding this comment.
Suggested change
| # We have to set weights_only to True as there are some non-tensor | |
| # We have to set weights_only to False as there are some non-tensor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes some state_dict gaps when integrating with TorchTitan: