Skip to content

Commit

Permalink
fix upload-artifact v4 issue in dynamic embedding wheel
Browse files Browse the repository at this point in the history
Summary:
# context
* TorchRec's OSS workflow "build dynamic embedding wheels" has been [failing](https://github.com/pytorch/torchrec/actions/runs/13416363464/job/37478091546) due to an upgrading of upload action [bug report](actions/upload-artifact#506)
* we saw similar error message as below
```
Run actions/upload-artifact@v4
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
```

# solution
* as described in this [migration.md](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md), adding additional job (merge) the artifacts.

Differential Revision: D69904715
  • Loading branch information
TroyGarden authored and facebook-github-bot committed Feb 20, 2025
1 parent 62c0740 commit 7bbf854
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions .github/workflows/build_dynamic_embedding_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,15 @@ jobs:
- name: Upload wheels
uses: actions/upload-artifact@v4
with:
name: artifact-${{ matrix.os }}/${{ matrix.pyver }}/cu${{ matrix.cuver }}
path: wheelhouse/*.whl

merge:
runs-on: ubuntu-latest
needs: build_wheels
steps:
- name: Merge Artifacts
uses: actions/upload-artifact/merge@v4
with:
name: artifact
pattern: artifact-*

0 comments on commit 7bbf854

Please sign in to comment.