Skip to content

Commit

Permalink
Clean up AWS credentials when building wheels (#1626)
Browse files Browse the repository at this point in the history
Summary:
This fixes the failures when building torchrec wheel using Nova build job.

Note that the credential `AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID` has been revoked and we are not using it anymore.  I can see it is still used in `.github/workflows/release_build.yml`, so please take priority action to:

* Either switch to ODIC like how we do it in Nova pytorch/test-infra#4865.  Please reach out to me if you need help on this.
* Or remove the workflow if it has been replaced by Nova.

Pull Request resolved: #1626

Reviewed By: henrylhtsang

Differential Revision: D52737705

Pulled By: huydhn

fbshipit-source-id: 79254f42666c6a444973a6d9bd5c13c43ebed0f6
  • Loading branch information
huydhn authored and facebook-github-bot committed Jan 12, 2024
1 parent fb25bf2 commit aa9c9ba
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/build-wheels-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ on:
- v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+
workflow_dispatch:

permissions:
id-token: write
contents: read

jobs:
generate-matrix:
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
Expand Down Expand Up @@ -58,6 +62,3 @@ jobs:
package-name: torchrec
smoke-test-script: ""
trigger-event: ${{ github.event_name }}
secrets:
AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID: ${{ secrets.AWS_PYTORCH_UPLOADER_ACCESS_KEY_ID }}
AWS_PYTORCH_UPLOADER_SECRET_ACCESS_KEY: ${{ secrets.AWS_PYTORCH_UPLOADER_SECRET_ACCESS_KEY }}

0 comments on commit aa9c9ba

Please sign in to comment.