Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs build workflow permission #1639

Closed
wants to merge 1 commit into from
Closed

Fix docs build workflow permission #1639

wants to merge 1 commit into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Jan 18, 2024

As reported by @henrylhtsang , the docs build workflow has been failing since we downgrade the default GITHUB_TOKEN permission to read-only org-wide. Write permission needs to be granted explicitly by the workflow now.

Testing

Run the workflow manually with my branch https://github.com/pytorch/torchrec/actions/runs/7574439344

@huydhn huydhn requested a review from henrylhtsang January 18, 2024 18:31
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2024
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit to pytorch/tnt that referenced this pull request Jan 19, 2024
Summary:
Similar to pytorch/torchrec#1639 and many other, this is to fix the doc build failures after we revoke the default write permission

Pull Request resolved: #685

Reviewed By: galrotem

Differential Revision: D52916577

Pulled By: huydhn

fbshipit-source-id: d069dbfef1dec6086c901cf37f9f3ced01955189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants