Fix embedding order in EmbeddingBagCollection #1646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: 1. The bug was introduced in D37352626 where we grouped tables by (pooling, data_type), but still used the original order for _embedding_names and _length_per_key. 1. Another bug was also introduced in D37352626 where we stacked embeddings with shape (batch, dim) along the batch dimension, but we should concat along the dim dimension. The unit tests didn't capture any of these bugs, because: 1. The numerical tolerance was too loose (1.0). This diff tightens it to 0.1. 2. The test inputs were not sufficient to trigger the bugs, e.g. the inputs only had one batch, one grouping key, and one embedding dim. Reviewed By: YazhiGao Differential Revision: D52894935
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52894935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The unit tests didn't capture any of these bugs, because:
Reviewed By: YazhiGao
Differential Revision: D52894935