Support Sync start and 'Naive' semi-sync #2050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: expand API to support: stash_gradients: bool, True -> dense optimizer will match sparse optimizer (B-2), False -> immediately apply dense optimizer, will be lower memory start_batch: int -> batch number to start semi-sync strategy Initution to date (ymmv): Ads is doing stash_gradients = False, but on MRS I saw NE regressions doing this. Reviewed By: henrylhtsang Differential Revision: D57640178 Privacy Context Container: 1203980333745195
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57640178 |
TroyGarden
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
expand API to support:
stash_gradients: bool, True -> dense optimizer will match sparse optimizer (B-2), False -> immediately apply dense optimizer, will be lower memory
start_batch: int -> batch number to start semi-sync strategy
Initution to date (ymmv):
Ads is doing stash_gradients = False, but on MRS I saw NE regressions doing this.
Reviewed By: henrylhtsang
Differential Revision:
D57640178
Privacy Context Container: 1203980333745195