Support empty tensor list #2053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57500720 |
xush6528
pushed a commit
to xush6528/torchrec
that referenced
this pull request
May 28, 2024
Summary: When we configure empty sparse feature list, the embedding lookup results could be an empty list. This is for unblocking the experiment in D57450566 (leaving only dense features in APS models) Reviewed By: joshuadeng Differential Revision: D57500720
xush6528
force-pushed
the
export-D57500720
branch
from
f0a6a26 to
d111477
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57500720 |
xush6528
pushed a commit
to xush6528/torchrec
that referenced
this pull request
May 28, 2024
Summary: When we configure empty sparse feature list, the embedding lookup results could be an empty list. This is for unblocking the experiment in D57450566 (leaving only dense features in APS models) Differential Revision: D57500720
xush6528
force-pushed
the
export-D57500720
branch
from
d111477 to
68dcba1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57500720 |
Summary: When we configure empty sparse feature list, the embedding lookup results could be an empty list. This is for unblocking the experiment in D57450566 (leaving only dense features in APS models) Reviewed By: dstaay-fb Differential Revision: D57500720
xush6528
force-pushed
the
export-D57500720
branch
from
68dcba1 to
b66dcb8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57500720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When we configure empty sparse feature list, the embedding lookup results could be an empty list.
This is for unblocking the experiment in D57450566 (leaving only dense features in APS models)
Reviewed By: joshuadeng
Differential Revision: D57500720