Enable AIT lowering for eager processed models on AIMP #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57297185 |
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
May 29, 2024
Summary: Fix Lowering for eager model processing path on AIMP. Before this diff, the device passed to merge_pooled_embeddings did not have an associated index, which will cause lowering to fail. Once index was present, refer to this post: https://fb.workplace.com/groups/gpuinference/permalink/830694592261282/, resulting in the need for the separate module as suggested by kflu Differential Revision: D57297185
PaulZhang12
force-pushed
the
export-D57297185
branch
from
47d1138 to
4821efb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57297185 |
PaulZhang12
force-pushed
the
export-D57297185
branch
from
4821efb to
ad6b721
Compare
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
Jun 3, 2024
Summary: Fix Lowering for eager model processing path on AIMP. Before this diff, the device passed to merge_pooled_embeddings did not have an associated index, which will cause lowering to fail. Once index was present, refer to this post: https://fb.workplace.com/groups/gpuinference/permalink/830694592261282/, resulting in the need for the separate module as suggested by kflu Differential Revision: D57297185
|
This pull request was exported from Phabricator. Differential Revision: D57297185 |
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
Jun 3, 2024
Summary: Fix Lowering for eager model processing path on AIMP. Before this diff, the device passed to merge_pooled_embeddings did not have an associated index, which will cause lowering to fail. Once index was present, refer to this post: https://fb.workplace.com/groups/gpuinference/permalink/830694592261282/, resulting in the need for the separate module as suggested by kflu Differential Revision: D57297185
PaulZhang12
force-pushed
the
export-D57297185
branch
from
ad6b721 to
fc31a70
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57297185 |
ZhengkaiZ
approved these changes
Jun 3, 2024
Summary: Fix Lowering for eager model processing path on AIMP. Before this diff, the device passed to merge_pooled_embeddings did not have an associated index, which will cause lowering to fail. Once index was present, refer to this post: https://fb.workplace.com/groups/gpuinference/permalink/830694592261282/, resulting in the need for the separate module as suggested by kflu Reviewed By: ZhengkaiZ Differential Revision: D57297185
PaulZhang12
force-pushed
the
export-D57297185
branch
from
fc31a70 to
b397e8d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57297185 |
PaulZhang12
added a commit
that referenced
this pull request
Jun 5, 2024
Summary: Pull Request resolved: #2055 Fix Lowering for eager model processing path on AIMP. Before this diff, the device passed to merge_pooled_embeddings did not have an associated index, which will cause lowering to fail. Once index was present, refer to this post: https://fb.workplace.com/groups/gpuinference/permalink/830694592261282/, resulting in the need for the separate module as suggested by kflu Reviewed By: ZhengkaiZ Differential Revision: D57297185 fbshipit-source-id: a2aa78c731dca91d123f7d7e91b8555d61cb890f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix Lowering for eager model processing path on AIMP. Before this diff, the device passed to merge_pooled_embeddings did not have an associated index, which will cause lowering to fail. Once index was present, refer to this post: https://fb.workplace.com/groups/gpuinference/permalink/830694592261282/, resulting in the need for the separate module as suggested by kflu
Differential Revision: D57297185