attempt to write specialized reshape code for 1d <-> 2d #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D58200241 |
facebook-github-bot
added
CLA Signed
Summary: Pull Request resolved: pytorch#2075 This diff contains torchrec changes that, together with a separate PyTorch PR, will ensure that uniform batch test with view conversions work in the existing torchrec tests. I am deliberately not including the changes in test_pt2_multiprocess.py that I used to test locally on my devserver. I will let the torchrec team decide if they want those changes in this diff or they prefer to do it themselves in a separate diff. Reviewed By: IvanKobzarev Differential Revision: D58200241
|
This pull request was exported from Phabricator. Differential Revision: D58200241 |
shazqadeer
force-pushed
the
export-D58200241
branch
from
6112e02 to
df21693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff contains torchrec changes that, together with a separate PyTorch PR, will ensure that uniform batch test with view conversions work in the existing torchrec tests.
I am deliberately not including the changes in test_pt2_multiprocess.py that I used to test locally on my devserver. I will let the torchrec team decide if they want those changes in this diff or they prefer to do it themselves in a separate diff.
Differential Revision: D58200241