Add APIs to detach/attach model to sdd pipeline #2076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Summary Adds 2 new user-facing APIs for `TrainPipelineSparseDist`: - `detach()` -> torch.nn.Module. Detaches original model so it can be used outside of current train pipeline. - `attach(model: Optional[torch.nn.Module] = none)` -> None. Attaches model to pipeline (i.e. override trec module forward and input dist fwds). If no model specified, uses original model. ## Sample use cases: - Bulk eval on trec sharded modules (e.g. ShardedEBC) after/during pipelined training. Currently this causes issues because the model forward is swapped with pipelined forward call. - Train on one pipeline (e.g. full-sync SDD), then swap to another pipeline (e.g. semi-sync) - Swap out model during training by calling `attach()` on another model (no current use case but is supported) Differential Revision: D57882281
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57882281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
Adds 2 new user-facing APIs for
TrainPipelineSparseDist:detach()-> torch.nn.Module. Detaches original model so it can be used outside of current train pipeline.attach(model: Optional[torch.nn.Module] = none)-> None. Attaches model to pipeline (i.e. override trec module forward and input dist fwds). If no model specified, uses original model.Sample use cases:
attach()on another model (no current use case but is supported)Differential Revision: D57882281