Fix FPEBC train pipeline test #2090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56950454 |
|
This pull request was exported from Phabricator. Differential Revision: D56950454 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jun 10, 2024
Summary: Pull Request resolved: pytorch#2090 3 issues that needed fixing: 1) Move batch to GPU 2) Set compute kernel to fused instead of dense to work w/ TW sharding 3) Ensure that input batch idlist_features KJT has max length equal to the max lengths specified for feature processors (otherwise it would fail on `torch.gather()` in feature processor due to shape mismatch between KJT input lengths and indices Reviewed By: henrylhtsang Differential Revision: D56950454
|
This pull request was exported from Phabricator. Differential Revision: D56950454 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jun 10, 2024
Summary: Pull Request resolved: pytorch#2090 3 issues that needed fixing: 1) Move batch to GPU 2) Set compute kernel to fused instead of dense to work w/ TW sharding 3) Ensure that input batch idlist_features KJT has max length equal to the max lengths specified for feature processors (otherwise it would fail on `torch.gather()` in feature processor due to shape mismatch between KJT input lengths and indices Reviewed By: henrylhtsang Differential Revision: D56950454
|
This pull request was exported from Phabricator. Differential Revision: D56950454 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jun 10, 2024
Summary: Pull Request resolved: pytorch#2090 3 issues that needed fixing: 1) Move batch to GPU 2) Set compute kernel to fused instead of dense to work w/ TW sharding 3) Ensure that input batch idlist_features KJT has max length equal to the max lengths specified for feature processors (otherwise it would fail on `torch.gather()` in feature processor due to shape mismatch between KJT input lengths and indices Reviewed By: henrylhtsang Differential Revision: D56950454
Differential Revision: D58254737
|
This pull request was exported from Phabricator. Differential Revision: D56950454 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: pytorch#2090 3 issues that needed fixing: 1) Move batch to GPU 2) Set compute kernel to fused instead of dense to work w/ TW sharding 3) Ensure that input batch idlist_features KJT has max length equal to the max lengths specified for feature processors (otherwise it would fail on `torch.gather()` in feature processor due to shape mismatch between KJT input lengths and indices Reviewed By: henrylhtsang Differential Revision: D56950454
Summary: Pull Request resolved: pytorch#2090 3 issues that needed fixing: 1) Move batch to GPU 2) Set compute kernel to fused instead of dense to work w/ TW sharding 3) Ensure that input batch idlist_features KJT has max length equal to the max lengths specified for feature processors (otherwise it would fail on `torch.gather()` in feature processor due to shape mismatch between KJT input lengths and indices Reviewed By: henrylhtsang Differential Revision: D56950454
|
This pull request was exported from Phabricator. Differential Revision: D56950454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
3 issues that needed fixing:
torch.gather()in feature processor due to shape mismatch between KJT input lengths and indicesDifferential Revision: D56950454